diff options
| author | vitalybuka@chromium.org <vitalybuka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-29 03:16:37 +0000 |
|---|---|---|
| committer | vitalybuka@chromium.org <vitalybuka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-29 03:16:37 +0000 |
| commit | e5324b55e4204451d02d9323a6ea013955b82bc0 (patch) | |
| tree | 369de1fdbf16aee58036f9a0a95c27bb9a0aa1e8 /printing/printing_context_no_system_dialog.h | |
| parent | b7898896f26bc424e1e11d7533f866c2872a8c4f (diff) | |
| download | chromium_src-e5324b55e4204451d02d9323a6ea013955b82bc0.zip chromium_src-e5324b55e4204451d02d9323a6ea013955b82bc0.tar.gz chromium_src-e5324b55e4204451d02d9323a6ea013955b82bc0.tar.bz2 | |
De-duplicate job_settings parsing code.
Proper set/get methods in PrintSettings.
Objective of this re-factoring is to simplify processing of
"print_to_pdf || is_cloud_dialog || print_to_cloud" case.
Now all platforms for this case do almost the same by in different way: calculate and set printing area.
In the next CL I'll move that code into common PrintingContext::UpdatePrintSettings and will ask platform specific implementation for desired page size only.
BUG=305731
Review URL: https://codereview.chromium.org/47823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231501 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'printing/printing_context_no_system_dialog.h')
| -rw-r--r-- | printing/printing_context_no_system_dialog.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/printing/printing_context_no_system_dialog.h b/printing/printing_context_no_system_dialog.h index 505f3186..f45fb46 100644 --- a/printing/printing_context_no_system_dialog.h +++ b/printing/printing_context_no_system_dialog.h @@ -27,9 +27,8 @@ class PRINTING_EXPORT PrintingContextNoSystemDialog : public PrintingContext { bool has_selection, const PrintSettingsCallback& callback) OVERRIDE; virtual Result UseDefaultSettings() OVERRIDE; - virtual Result UpdatePrinterSettings( - const base::DictionaryValue& job_settings, - const PageRanges& ranges) OVERRIDE; + virtual Result UpdatePrinterSettings(bool target_is_pdf, + bool external_preview) OVERRIDE; virtual Result InitWithSettings(const PrintSettings& settings) OVERRIDE; virtual Result NewDocument(const base::string16& document_name) OVERRIDE; virtual Result NewPage() OVERRIDE; |