Small PrintingContextTest cleanup.

Review URL: https://codereview.chromium.org/209973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259929 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 111 insertions, 103 deletions

diff --git a/printing/printing_context_win_unittest.cc b/printing/printing_context_win_unittest.cc
index 79e7637..c9facc9 100644
--- a/printing/printing_context_win_unittest.cc
+++ b/printing/printing_context_win_unittest.cc
@@ -35,112 +35,122 @@ class PrintingContextTest : public PrintingTest<testing::Test> {
   PrintingContext::Result result_;
 };
 
-// This is a fake PrintDlgEx implementation that sets the right fields in
-// |lppd| to trigger a bug in older revisions of PrintingContext.
-HRESULT WINAPI PrintDlgExMock(LPPRINTDLGEX lppd) {
-  // The interesting bits:
-  // Pretend the user hit print
-  lppd->dwResultAction = PD_RESULT_PRINT;
-
-  // Pretend the page range is 1-5, but since lppd->Flags does not have
-  // PD_SELECTION set, this really shouldn't matter.
-  lppd->nPageRanges = 1;
-  lppd->lpPageRanges[0].nFromPage = 1;
-  lppd->lpPageRanges[0].nToPage = 5;
-
-  base::string16 printer_name = PrintingContextTest::GetDefaultPrinter();
-  ScopedPrinterHandle printer;
-  if (!printer.OpenPrinter(printer_name.c_str()))
-    return E_FAIL;
-
-  scoped_ptr<uint8[]> buffer;
-  const DEVMODE* dev_mode = NULL;
-  HRESULT result = S_OK;
-  lppd->hDC = NULL;
-  lppd->hDevMode = NULL;
-  lppd->hDevNames = NULL;
-
-  PrinterInfo2 info_2;
-  if (info_2.Init(printer)) {
-    dev_mode = info_2.get()->pDevMode;
-  }
-  if (!dev_mode) {
-    result = E_FAIL;
-    goto Cleanup;
-  }
+class MockPrintingContextWin : public PrintingContextWin {
+ public:
+  MockPrintingContextWin() : PrintingContextWin("") {}
 
-  if (!PrintingContextWin::AllocateContext(printer_name, dev_mode,
-                                           &lppd->hDC)) {
-    result = E_FAIL;
-    goto Cleanup;
-  }
+ protected:
+  // This is a fake PrintDlgEx implementation that sets the right fields in
+  // |lppd| to trigger a bug in older revisions of PrintingContext.
+  HRESULT ShowPrintDialog(PRINTDLGEX* lppd) OVERRIDE {
+    // The interesting bits:
+    // Pretend the user hit print
+    lppd->dwResultAction = PD_RESULT_PRINT;
+
+    // Pretend the page range is 1-5, but since lppd->Flags does not have
+    // PD_SELECTION set, this really shouldn't matter.
+    lppd->nPageRanges = 1;
+    lppd->lpPageRanges[0].nFromPage = 1;
+    lppd->lpPageRanges[0].nToPage = 5;
+
+    base::string16 printer_name = PrintingContextTest::GetDefaultPrinter();
+    ScopedPrinterHandle printer;
+    if (!printer.OpenPrinter(printer_name.c_str()))
+      return E_FAIL;
+
+    scoped_ptr<uint8[]> buffer;
+    const DEVMODE* dev_mode = NULL;
+    HRESULT result = S_OK;
+    lppd->hDC = NULL;
+    lppd->hDevMode = NULL;
+    lppd->hDevNames = NULL;
+
+    PrinterInfo2 info_2;
+    if (info_2.Init(printer)) {
+      dev_mode = info_2.get()->pDevMode;
+    }
+    if (!dev_mode) {
+      result = E_FAIL;
+      goto Cleanup;
+    }
 
-  size_t dev_mode_size = dev_mode->dmSize + dev_mode->dmDriverExtra;
-  lppd->hDevMode = GlobalAlloc(GMEM_MOVEABLE, dev_mode_size);
-  if (!lppd->hDevMode) {
-    result = E_FAIL;
-    goto Cleanup;
-  }
-  void* dev_mode_ptr = GlobalLock(lppd->hDevMode);
-  if (!dev_mode_ptr) {
-    result = E_FAIL;
-    goto Cleanup;
-  }
-  memcpy(dev_mode_ptr, dev_mode, dev_mode_size);
-  GlobalUnlock(lppd->hDevMode);
-  dev_mode_ptr = NULL;
-
-  size_t driver_size = 2 + sizeof(wchar_t) * lstrlen(info_2.get()->pDriverName);
-  size_t printer_size = 2 + sizeof(wchar_t) *
-                            lstrlen(info_2.get()->pPrinterName);
-  size_t port_size = 2 + sizeof(wchar_t) * lstrlen(info_2.get()->pPortName);
-  size_t dev_names_size = sizeof(DEVNAMES) + driver_size + printer_size +
-                          port_size;
-  lppd->hDevNames = GlobalAlloc(GHND, dev_names_size);
-  if (!lppd->hDevNames) {
-    result = E_FAIL;
-    goto Cleanup;
-  }
-  void* dev_names_ptr = GlobalLock(lppd->hDevNames);
-  if (!dev_names_ptr) {
-    result = E_FAIL;
-    goto Cleanup;
-  }
-  DEVNAMES* dev_names = reinterpret_cast<DEVNAMES*>(dev_names_ptr);
-  dev_names->wDefault = 1;
-  dev_names->wDriverOffset = sizeof(DEVNAMES) / sizeof(wchar_t);
-  memcpy(reinterpret_cast<uint8*>(dev_names_ptr) + dev_names->wDriverOffset,
-         info_2.get()->pDriverName, driver_size);
-  dev_names->wDeviceOffset = dev_names->wDriverOffset +
-                             driver_size / sizeof(wchar_t);
-  memcpy(reinterpret_cast<uint8*>(dev_names_ptr) + dev_names->wDeviceOffset,
-         info_2.get()->pPrinterName, printer_size);
-  dev_names->wOutputOffset = dev_names->wDeviceOffset +
-                             printer_size / sizeof(wchar_t);
-  memcpy(reinterpret_cast<uint8*>(dev_names_ptr) + dev_names->wOutputOffset,
-         info_2.get()->pPortName, port_size);
-  GlobalUnlock(lppd->hDevNames);
-  dev_names_ptr = NULL;
-
-Cleanup:
-  // Note: This section does proper deallocation/free of DC/global handles.  We
-  //       did not use ScopedHGlobal or ScopedHandle because they did not
-  //       perform what we need.  Goto's are used based on Windows programming
-  //       idiom, to avoid deeply nested if's, and try-catch-finally is not
-  //       allowed in Chromium.
-  if (FAILED(result)) {
-    if (lppd->hDC) {
-      DeleteDC(lppd->hDC);
+    if (!PrintingContextWin::AllocateContext(
+            printer_name, dev_mode, &lppd->hDC)) {
+      result = E_FAIL;
+      goto Cleanup;
+    }
+
+    size_t dev_mode_size = dev_mode->dmSize + dev_mode->dmDriverExtra;
+    lppd->hDevMode = GlobalAlloc(GMEM_MOVEABLE, dev_mode_size);
+    if (!lppd->hDevMode) {
+      result = E_FAIL;
+      goto Cleanup;
     }
-    if (lppd->hDevMode) {
-      GlobalFree(lppd->hDevMode);
+    void* dev_mode_ptr = GlobalLock(lppd->hDevMode);
+    if (!dev_mode_ptr) {
+      result = E_FAIL;
+      goto Cleanup;
     }
-    if (lppd->hDevNames) {
-      GlobalFree(lppd->hDevNames);
+    memcpy(dev_mode_ptr, dev_mode, dev_mode_size);
+    GlobalUnlock(lppd->hDevMode);
+    dev_mode_ptr = NULL;
+
+    size_t driver_size =
+        2 + sizeof(wchar_t) * lstrlen(info_2.get()->pDriverName);
+    size_t printer_size =
+        2 + sizeof(wchar_t) * lstrlen(info_2.get()->pPrinterName);
+    size_t port_size = 2 + sizeof(wchar_t) * lstrlen(info_2.get()->pPortName);
+    size_t dev_names_size =
+        sizeof(DEVNAMES) + driver_size + printer_size + port_size;
+    lppd->hDevNames = GlobalAlloc(GHND, dev_names_size);
+    if (!lppd->hDevNames) {
+      result = E_FAIL;
+      goto Cleanup;
     }
+    void* dev_names_ptr = GlobalLock(lppd->hDevNames);
+    if (!dev_names_ptr) {
+      result = E_FAIL;
+      goto Cleanup;
+    }
+    DEVNAMES* dev_names = reinterpret_cast<DEVNAMES*>(dev_names_ptr);
+    dev_names->wDefault = 1;
+    dev_names->wDriverOffset = sizeof(DEVNAMES) / sizeof(wchar_t);
+    memcpy(reinterpret_cast<uint8*>(dev_names_ptr) + dev_names->wDriverOffset,
+           info_2.get()->pDriverName,
+           driver_size);
+    dev_names->wDeviceOffset =
+        dev_names->wDriverOffset + driver_size / sizeof(wchar_t);
+    memcpy(reinterpret_cast<uint8*>(dev_names_ptr) + dev_names->wDeviceOffset,
+           info_2.get()->pPrinterName,
+           printer_size);
+    dev_names->wOutputOffset =
+        dev_names->wDeviceOffset + printer_size / sizeof(wchar_t);
+    memcpy(reinterpret_cast<uint8*>(dev_names_ptr) + dev_names->wOutputOffset,
+           info_2.get()->pPortName,
+           port_size);
+    GlobalUnlock(lppd->hDevNames);
+    dev_names_ptr = NULL;
+
+  Cleanup:
+    // Note: This section does proper deallocation/free of DC/global handles. We
+    //       did not use ScopedHGlobal or ScopedHandle because they did not
+    //       perform what we need.  Goto's are used based on Windows programming
+    //       idiom, to avoid deeply nested if's, and try-catch-finally is not
+    //       allowed in Chromium.
+    if (FAILED(result)) {
+      if (lppd->hDC) {
+        DeleteDC(lppd->hDC);
+      }
+      if (lppd->hDevMode) {
+        GlobalFree(lppd->hDevMode);
+      }
+      if (lppd->hDevNames) {
+        GlobalFree(lppd->hDevNames);
+      }
+    }
+    return result;
   }
-  return result;
-}
+};
 
 TEST_F(PrintingContextTest, Base) {
   if (IsTestCaseDisabled())
@@ -164,9 +174,7 @@ TEST_F(PrintingContextTest, PrintAll) {
   if (IsTestCaseDisabled())
     return;
 
-  std::string dummy_locale;
-  PrintingContextWin context(dummy_locale);
-  context.SetPrintDialog(&PrintDlgExMock);
+  MockPrintingContextWin context;
   context.AskUserForSettings(
       NULL, 123, false, base::Bind(&PrintingContextTest::PrintSettingsCallback,
                                    base::Unretained(this)));