summaryrefslogtreecommitdiffstats
path: root/printing
diff options
context:
space:
mode:
authorthestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-22 01:18:30 +0000
committerthestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-22 01:18:30 +0000
commitc82d3f217fca306f829576576f7b717871a85b00 (patch)
tree8d652a1c3d9116402e1d9000f1a4991c1b5ab727 /printing
parent4ae76407bbc22f05c79b8255e8337ea0cc907dc2 (diff)
downloadchromium_src-c82d3f217fca306f829576576f7b717871a85b00.zip
chromium_src-c82d3f217fca306f829576576f7b717871a85b00.tar.gz
chromium_src-c82d3f217fca306f829576576f7b717871a85b00.tar.bz2
Printing: Use const reference instead of a const pointer.
BUG=none TEST=none Review URL: http://codereview.chromium.org/6675013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78955 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'printing')
-rw-r--r--printing/printing_context.h2
-rw-r--r--printing/printing_context_cairo.cc2
-rw-r--r--printing/printing_context_cairo.h2
-rw-r--r--printing/printing_context_mac.h2
-rw-r--r--printing/printing_context_mac.mm4
-rw-r--r--printing/printing_context_win.cc2
-rw-r--r--printing/printing_context_win.h2
7 files changed, 8 insertions, 8 deletions
diff --git a/printing/printing_context.h b/printing/printing_context.h
index dca306b..c4e2094 100644
--- a/printing/printing_context.h
+++ b/printing/printing_context.h
@@ -51,7 +51,7 @@ class PrintingContext {
// Updates print settings. |job_settings| contains all print job settings
// information. |ranges| has the new page range settings.
- virtual Result UpdatePrintSettings(const DictionaryValue* const job_settings,
+ virtual Result UpdatePrintSettings(const DictionaryValue& job_settings,
const PageRanges& ranges) = 0;
// Initializes with predefined settings.
diff --git a/printing/printing_context_cairo.cc b/printing/printing_context_cairo.cc
index cb7a092..75dac3e 100644
--- a/printing/printing_context_cairo.cc
+++ b/printing/printing_context_cairo.cc
@@ -149,7 +149,7 @@ PrintingContext::Result PrintingContextCairo::UseDefaultSettings() {
}
PrintingContext::Result PrintingContextCairo::UpdatePrintSettings(
- const DictionaryValue* const job_settings, const PageRanges& ranges) {
+ const DictionaryValue& job_settings, const PageRanges& ranges) {
DCHECK(!in_print_job_);
settings_.ranges = ranges;
diff --git a/printing/printing_context_cairo.h b/printing/printing_context_cairo.h
index 192782f..caee1e3 100644
--- a/printing/printing_context_cairo.h
+++ b/printing/printing_context_cairo.h
@@ -40,7 +40,7 @@ class PrintingContextCairo : public PrintingContext {
bool has_selection,
PrintSettingsCallback* callback);
virtual Result UseDefaultSettings();
- virtual Result UpdatePrintSettings(const DictionaryValue* const job_settings,
+ virtual Result UpdatePrintSettings(const DictionaryValue& job_settings,
const PageRanges& ranges);
virtual Result InitWithSettings(const PrintSettings& settings);
virtual Result NewDocument(const string16& document_name);
diff --git a/printing/printing_context_mac.h b/printing/printing_context_mac.h
index e87dfce..78b85c0 100644
--- a/printing/printing_context_mac.h
+++ b/printing/printing_context_mac.h
@@ -29,7 +29,7 @@ class PrintingContextMac : public PrintingContext {
bool has_selection,
PrintSettingsCallback* callback);
virtual Result UseDefaultSettings();
- virtual Result UpdatePrintSettings(const DictionaryValue* const job_settings,
+ virtual Result UpdatePrintSettings(const DictionaryValue& job_settings,
const PageRanges& ranges);
virtual Result InitWithSettings(const PrintSettings& settings);
virtual Result NewDocument(const string16& document_name);
diff --git a/printing/printing_context_mac.mm b/printing/printing_context_mac.mm
index 1e354e0..a5d9b33 100644
--- a/printing/printing_context_mac.mm
+++ b/printing/printing_context_mac.mm
@@ -82,7 +82,7 @@ PrintingContext::Result PrintingContextMac::UseDefaultSettings() {
}
PrintingContext::Result PrintingContextMac::UpdatePrintSettings(
- const DictionaryValue* const job_settings, const PageRanges& ranges) {
+ const DictionaryValue& job_settings, const PageRanges& ranges) {
DCHECK(!in_print_job_);
// TODO (kmadhusu): Update other print job settings such as number of copies,
@@ -92,7 +92,7 @@ PrintingContext::Result PrintingContextMac::UpdatePrintSettings(
print_info_.reset([[NSPrintInfo sharedPrintInfo] copy]);
std::string printer_name;
- if (!job_settings->GetString("printerName", &printer_name))
+ if (!job_settings.GetString("printerName", &printer_name))
return OnError();
NSString* new_printer_name = base::SysUTF8ToNSString(printer_name);
diff --git a/printing/printing_context_win.cc b/printing/printing_context_win.cc
index 819c0077..23832ad 100644
--- a/printing/printing_context_win.cc
+++ b/printing/printing_context_win.cc
@@ -210,7 +210,7 @@ PrintingContext::Result PrintingContextWin::UseDefaultSettings() {
}
PrintingContext::Result PrintingContextWin::UpdatePrintSettings(
- const DictionaryValue* const job_settings, const PageRanges& ranges) {
+ const DictionaryValue& job_settings, const PageRanges& ranges) {
DCHECK(!in_print_job_);
settings_.ranges = ranges;
diff --git a/printing/printing_context_win.h b/printing/printing_context_win.h
index a1af2bb..d949966 100644
--- a/printing/printing_context_win.h
+++ b/printing/printing_context_win.h
@@ -28,7 +28,7 @@ class PrintingContextWin : public PrintingContext {
bool has_selection,
PrintSettingsCallback* callback);
virtual Result UseDefaultSettings();
- virtual Result UpdatePrintSettings(const DictionaryValue* const job_settings,
+ virtual Result UpdatePrintSettings(const DictionaryValue& job_settings,
const PageRanges& ranges);
virtual Result InitWithSettings(const PrintSettings& settings);
virtual Result NewDocument(const string16& document_name);