diff options
| author | abodenha@google.com <abodenha@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-27 20:59:47 +0000 |
|---|---|---|
| committer | abodenha@google.com <abodenha@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-27 20:59:47 +0000 |
| commit | b0235fb426ebdb1a795b64b948f55e3480d129f6 (patch) | |
| tree | f03bdb502fd238e83d0ad147092cf3c87a162722 /printing | |
| parent | 0f22d775b47090b022ffd5a93d12858b8c9f9148 (diff) | |
| download | chromium_src-b0235fb426ebdb1a795b64b948f55e3480d129f6.zip chromium_src-b0235fb426ebdb1a795b64b948f55e3480d129f6.tar.gz chromium_src-b0235fb426ebdb1a795b64b948f55e3480d129f6.tar.bz2 | |
Refactored code to move cloudprint specific code into print_preview_cloud.js.
Removed "Local" and "Cloud" labels from dropdown
The "More printers" label is now more clear and shares behavior with the cloud print printer option in Chrome.
The system print dialog link is replaced with a similar link referencing cloud print in chrome os.
Choosing cloud print from the printers dropdown now requires the user to hit print before opening the cloud print dialog.
Fixed broken tests.
BUG=88098, 97175, http://code.google.com/p/chromium-os/issues/detail?id=16082, http://code.google.com/p/chromium-os/issues/detail?id=20121, http://code.google.com/p/chromium-os/issues/detail?id=20119
TEST=Enable print preview in about:flags. Printing should work with cloud print printers in much the same way as local printers in Chrome
Review URL: http://codereview.chromium.org/7976017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103010 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'printing')
| -rw-r--r-- | printing/print_job_constants.cc | 3 | ||||
| -rw-r--r-- | printing/print_job_constants.h | 1 |
2 files changed, 4 insertions, 0 deletions
diff --git a/printing/print_job_constants.cc b/printing/print_job_constants.cc index 0edea06..fa99f25 100644 --- a/printing/print_job_constants.cc +++ b/printing/print_job_constants.cc @@ -18,6 +18,9 @@ const char kPreviewUIAddr[] = "previewUIAddr"; // Print using cloud print: true if selected, false if not. const char kSettingCloudPrintId[] = "cloudPrintID"; +// Print using cloud print dialog: true if selected, false if not. +const char kSettingCloudPrintDialog[] = "printWithCloudPrint"; + // Print job setting 'collate'. const char kSettingCollate[] = "collate"; diff --git a/printing/print_job_constants.h b/printing/print_job_constants.h index ebd63c2..cbdad74 100644 --- a/printing/print_job_constants.h +++ b/printing/print_job_constants.h @@ -13,6 +13,7 @@ PRINTING_EXPORT extern const char kIsFirstRequest[]; PRINTING_EXPORT extern const char kPreviewRequestID[]; PRINTING_EXPORT extern const char kPreviewUIAddr[]; PRINTING_EXPORT extern const char kSettingCloudPrintId[]; +PRINTING_EXPORT extern const char kSettingCloudPrintDialog[]; PRINTING_EXPORT extern const char kSettingCollate[]; PRINTING_EXPORT extern const char kSettingColor[]; PRINTING_EXPORT extern const char kSettingContentHeight[]; |