diff options
author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-29 06:49:30 +0000 |
---|---|---|
committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-29 06:49:30 +0000 |
commit | 732fa94a7ac29dd39eb6afcb321ba97921660383 (patch) | |
tree | b075741f6fe9b3a067d1a32321428a38a10069e1 /printing | |
parent | 63a8ba1e1fb71156beff23b4a26828dbc387c734 (diff) | |
download | chromium_src-732fa94a7ac29dd39eb6afcb321ba97921660383.zip chromium_src-732fa94a7ac29dd39eb6afcb321ba97921660383.tar.gz chromium_src-732fa94a7ac29dd39eb6afcb321ba97921660383.tar.bz2 |
Linux: clean up the usage of "use_cups" gyp switch:
This CL removes duplication and fixes a build error
on system with no CUPS. It uses cups-config instead of
hardcoding flags.
Also, it removes a superfluous dependency on gcrypt
from chrome_browser.gypi. printing uses gcrypt explicitly,
but chrome/browser doesn't. It was just blindly copy-pasted.
I just extracted libgcrypt target to build/linux/system.gyp,
and switched to libgcrypt-config instead of hardcoding flags.
BUG=none
Review URL: http://codereview.chromium.org/6883221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83489 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'printing')
-rw-r--r-- | printing/printing.gyp | 54 |
1 files changed, 38 insertions, 16 deletions
diff --git a/printing/printing.gyp b/printing/printing.gyp index 1a39bfd..e3cafd2 100644 --- a/printing/printing.gyp +++ b/printing/printing.gyp @@ -125,6 +125,16 @@ ], }], ['use_cups==1', { + 'dependencies': [ + 'cups', + ], + 'conditions': [ + ['OS!="mac"', { + 'dependencies': [ + '../build/linux/system.gyp:libgcrypt', + ], + }], + ], 'defines': [ # PRINT_BACKEND_AVAILABLE disables the default dummy implementation # of the print backend and enables a custom implementation instead. @@ -135,22 +145,6 @@ 'backend/cups_helper.h', 'backend/print_backend_cups.cc', ], - 'conditions': [ - ['OS=="mac"', { - 'link_settings': { - 'libraries': [ - '$(SDKROOT)/usr/lib/libcups.dylib', - ] - }, - }, { - 'link_settings': { - 'libraries': [ - '-lcups', - '-lgcrypt', - ], - }, - }], - ], }], ], }, @@ -201,6 +195,34 @@ }], ], }, + { + 'target_name': 'cups', + 'type': 'none', + 'conditions': [ + ['use_cups==1', { + 'direct_dependent_settings': { + 'defines': [ + 'USE_CUPS', + ], + 'conditions': [ + ['OS=="mac"', { + 'link_settings': { + 'libraries': [ + '$(SDKROOT)/usr/lib/libcups.dylib', + ] + }, + }, { + 'link_settings': { + 'libraries': [ + '<!@(cups-config --libs)', + ], + }, + }], + ], + }, + }], + ], + }, ], } |