diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-30 17:29:27 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-30 17:29:27 +0000 |
| commit | 40350b13714bed9c76d8bb0991c490b2ee14fe05 (patch) | |
| tree | ab2c88b3f9f5ba6e179a4547fb6b47bd3a768e95 /printing | |
| parent | 3450c47c2b62b3db03c3d3a873252072baecd40c (diff) | |
| download | chromium_src-40350b13714bed9c76d8bb0991c490b2ee14fe05.zip chromium_src-40350b13714bed9c76d8bb0991c490b2ee14fe05.tar.gz chromium_src-40350b13714bed9c76d8bb0991c490b2ee14fe05.tar.bz2 | |
Minor C++ fixes found by Clang.
In cases where I've added an #include, it's generally due to Clang being
more picky about templates being available during expansions.
Review URL: http://codereview.chromium.org/1432003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43098 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'printing')
| -rw-r--r-- | printing/pdf_ps_metafile_cairo.cc | 9 | ||||
| -rw-r--r-- | printing/pdf_ps_metafile_cairo.h | 2 |
2 files changed, 8 insertions, 3 deletions
diff --git a/printing/pdf_ps_metafile_cairo.cc b/printing/pdf_ps_metafile_cairo.cc index 31c1e8a..fc2efda 100644 --- a/printing/pdf_ps_metafile_cairo.cc +++ b/printing/pdf_ps_metafile_cairo.cc @@ -358,8 +358,13 @@ bool PdfPsMetafile::SaveTo(const base::FileDescriptor& fd) const { success = false; } - if (fd.auto_close) - HANDLE_EINTR(close(fd.fd)); + if (fd.auto_close) { + if (HANDLE_EINTR(close(fd.fd)) < 0) { + DPLOG(WARNING) << "close"; + success = false; + } + } + return success; } diff --git a/printing/pdf_ps_metafile_cairo.h b/printing/pdf_ps_metafile_cairo.h index eff10d1..9930f5b 100644 --- a/printing/pdf_ps_metafile_cairo.h +++ b/printing/pdf_ps_metafile_cairo.h @@ -13,7 +13,7 @@ typedef struct _cairo_surface cairo_surface_t; typedef struct _cairo cairo_t; namespace base { -class FileDescriptor; +struct FileDescriptor; } class FilePath; |