summaryrefslogtreecommitdiffstats
path: root/printing
diff options
context:
space:
mode:
authorestade <estade@chromium.org>2015-05-15 18:02:34 -0700
committerCommit bot <commit-bot@chromium.org>2015-05-16 01:02:46 +0000
commit8d04646294767ea1f3a7da596547b465d50cb4d1 (patch)
tree6bd6194b6fe2ac226114f9125570bd605e9b6d42 /printing
parentf39e5aff5aae8451a7ef190a2fc822bf80c4e30d (diff)
downloadchromium_src-8d04646294767ea1f3a7da596547b465d50cb4d1.zip
chromium_src-8d04646294767ea1f3a7da596547b465d50cb4d1.tar.gz
chromium_src-8d04646294767ea1f3a7da596547b465d50cb4d1.tar.bz2
Convert JsonWriter::Write to taking a const ref for the in-param
Clearer API; flushes out a lot of unnecessary heap allocations. depends on https://codereview.chromium.org/1129083003/ BUG=none Review URL: https://codereview.chromium.org/1131113004 Cr-Commit-Position: refs/heads/master@{#330255}
Diffstat (limited to 'printing')
-rw-r--r--printing/printed_document.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/printing/printed_document.cc b/printing/printed_document.cc
index 62fbef8..3b17eff 100644
--- a/printing/printed_document.cc
+++ b/printing/printed_document.cc
@@ -78,7 +78,7 @@ void DebugDumpSettings(const base::string16& doc_name,
PrintSettingsToJobSettingsDebug(settings, &job_settings);
std::string settings_str;
base::JSONWriter::WriteWithOptions(
- &job_settings, base::JSONWriter::OPTIONS_PRETTY_PRINT, &settings_str);
+ job_settings, base::JSONWriter::OPTIONS_PRETTY_PRINT, &settings_str);
scoped_refptr<base::RefCountedMemory> data =
base::RefCountedString::TakeString(&settings_str);
blocking_runner->PostTask(