diff options
author | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-29 00:38:11 +0000 |
---|---|---|
committer | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-29 00:38:11 +0000 |
commit | f164f48593d7c3d9ace978e00221e46423de1b65 (patch) | |
tree | 66b5e89c4b736e5b1414436ba1cb68cab902bbfc /remoting/client/client_util_unittest.cc | |
parent | f4dafe029aab967bbc6ec5ad28c9f928280367f3 (diff) | |
download | chromium_src-f164f48593d7c3d9ace978e00221e46423de1b65.zip chromium_src-f164f48593d7c3d9ace978e00221e46423de1b65.tar.gz chromium_src-f164f48593d7c3d9ace978e00221e46423de1b65.tar.bz2 |
Reapply 53892 with ARM build fix as suggested by Kobic.
For some reason, the ARM g++ thinks that comparing a pointer to a class
method against NULL is using NULL for arithemtic. Switching to compare
against 0 makes this go away. TODO added to investigate what is going on.
Original Review URL: http://codereview.chromium.org/3064009
TBR: hclam@chromium.org
BUG=50248
TEST=reproed locally with CodeSourcery g++ and verified change fixed things.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54083 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting/client/client_util_unittest.cc')
-rw-r--r-- | remoting/client/client_util_unittest.cc | 17 |
1 files changed, 1 insertions, 16 deletions
diff --git a/remoting/client/client_util_unittest.cc b/remoting/client/client_util_unittest.cc index 4277769..b1c3d21 100644 --- a/remoting/client/client_util_unittest.cc +++ b/remoting/client/client_util_unittest.cc @@ -10,26 +10,11 @@ namespace remoting { -// TODO(ajwong): Once ChromotingPlugin stablizes a little more, come up with -// sane unittests. +// TODO(ajwong): Fill this out. class ClientUtilTest : public testing::Test { protected: virtual void SetUp() { } }; -TEST_F(ClientUtilTest, GetLoginInfoFromUrlParams) { - const char url[] = "chromotocol://hostid?user=auser&auth=someauth&jid=ajid"; - std::string user_id; - std::string auth_token; - std::string host_jid; - ClientConfig config; - - ASSERT_TRUE(GetLoginInfoFromUrlParams(url, &config)); - - EXPECT_EQ("auser", config.username); - EXPECT_EQ("someauth", config.auth_token); - EXPECT_EQ("ajid", config.host_jid); -} - } // namespace remoting |