diff options
author | lambroslambrou@chromium.org <lambroslambrou@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-13 18:17:30 +0000 |
---|---|---|
committer | lambroslambrou@chromium.org <lambroslambrou@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-13 18:17:30 +0000 |
commit | b25ff3b40b859a512f38106bd04010dac9412bd6 (patch) | |
tree | d14ef420f85b380bd99756ce5d5d6668237477fd /remoting/client/input_handler.cc | |
parent | d4fe2317514900f7a70cb61da28bc3fced7da974 (diff) | |
download | chromium_src-b25ff3b40b859a512f38106bd04010dac9412bd6.zip chromium_src-b25ff3b40b859a512f38106bd04010dac9412bd6.tar.gz chromium_src-b25ff3b40b859a512f38106bd04010dac9412bd6.tar.bz2 |
Refactor InputStub interface to pass events by value (const reference).
This will make it much easier to inject modified key/mouse events, for example,
restricting mouse-coordinates to the screen area.
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7803004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100939 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting/client/input_handler.cc')
-rw-r--r-- | remoting/client/input_handler.cc | 27 |
1 files changed, 12 insertions, 15 deletions
diff --git a/remoting/client/input_handler.cc b/remoting/client/input_handler.cc index 690ce04..7b48d89 100644 --- a/remoting/client/input_handler.cc +++ b/remoting/client/input_handler.cc @@ -34,22 +34,20 @@ void InputHandler::SendKeyEvent(bool press, int keycode) { pressed_keys_.erase(keycode); } - KeyEvent* event = new KeyEvent(); - event->set_keycode(keycode); - event->set_pressed(press); - - stub->InjectKeyEvent(event, new DeleteTask<KeyEvent>(event)); + KeyEvent event; + event.set_keycode(keycode); + event.set_pressed(press); + stub->InjectKeyEvent(event); } } void InputHandler::SendMouseMoveEvent(int x, int y) { protocol::InputStub* stub = connection_->input_stub(); if (stub) { - MouseEvent* event = new MouseEvent(); - event->set_x(x); - event->set_y(y); - - stub->InjectMouseEvent(event, new DeleteTask<MouseEvent>(event)); + MouseEvent event; + event.set_x(x); + event.set_y(y); + stub->InjectMouseEvent(event); } } @@ -57,11 +55,10 @@ void InputHandler::SendMouseButtonEvent(bool button_down, MouseEvent::MouseButton button) { protocol::InputStub* stub = connection_->input_stub(); if (stub) { - MouseEvent* event = new MouseEvent(); - event->set_button(button); - event->set_button_down(button_down); - - stub->InjectMouseEvent(event, new DeleteTask<MouseEvent>(event)); + MouseEvent event; + event.set_button(button); + event.set_button_down(button_down); + stub->InjectMouseEvent(event); } } |