diff options
| author | alexeypa@google.com <alexeypa@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-26 23:04:24 +0000 |
|---|---|---|
| committer | alexeypa@google.com <alexeypa@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-26 23:04:24 +0000 |
| commit | 93cfcc6f75ffd86895a6f95013b7df8becccfb91 (patch) | |
| tree | dec5252259e825efd3db95cd7096880b0df54f01 /remoting/host/basic_desktop_environment.cc | |
| parent | 40f42682afc1bd543f9fde452f7f1f20fcf55492 (diff) | |
| download | chromium_src-93cfcc6f75ffd86895a6f95013b7df8becccfb91.zip chromium_src-93cfcc6f75ffd86895a6f95013b7df8becccfb91.tar.gz chromium_src-93cfcc6f75ffd86895a6f95013b7df8becccfb91.tar.bz2 | |
Revert 213997 "Localized Chromoting Host on Mac and Linux."
It passed CQ but broke Linux Builder. I'm filing a bug agains CQ.
> Localized Chromoting Host on Mac and Linux.
>
> This CL implements generation of localizable strings from remoting_strings.grd file. Depending on the platform the localized resources are placed to:
> - Mac: localized .string and .pak resources are added to each application bundle under 'Resources/<locale>.lproj'
> - Linux: localized .pak files are placed under 'remoting_locales' directory next to the binary locading them.
> - Windows: .rc resources are generated from .jinja2 templates and embedded into a relevant binary.
>
> Chrome l10n and i18n APIs are used to retrieve the current locale and RTL flag (Mac & Linux). The it2me plugin sets the locale to match the locale of the browser.
>
> Collateral changes:
> - UiString is not used any more.
> - Increased width of disconnect window message on Mac.
> - The host plugin version is correctly reported on Mac.
> - Dialogs use RTL templates in case of RTL languages. No more updating the templates dynamically (Windows).
> - remoting_unittests.ResourcesTest row runs on Mac, LInux and Windows.
> - '@' is used for variable substitutions by remoting_localize.py.
> - HOST_PLUGIN_MIME_TYPE is defined in one place now.
> - Deleted unused commong_resources.grd.
>
> Mac installer and preference panel are not localized yet.
>
> BUG=155204
>
> Review URL: https://chromiumcodereview.appspot.com/19803010
TBR=alexeypa@chromium.org
Review URL: https://codereview.chromium.org/20854002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213998 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting/host/basic_desktop_environment.cc')
| -rw-r--r-- | remoting/host/basic_desktop_environment.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/remoting/host/basic_desktop_environment.cc b/remoting/host/basic_desktop_environment.cc index 7698ca8..e6e2db3 100644 --- a/remoting/host/basic_desktop_environment.cc +++ b/remoting/host/basic_desktop_environment.cc @@ -66,10 +66,12 @@ BasicDesktopEnvironment::BasicDesktopEnvironment( BasicDesktopEnvironmentFactory::BasicDesktopEnvironmentFactory( scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner, scoped_refptr<base::SingleThreadTaskRunner> input_task_runner, - scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner) + scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner, + const UiStrings& ui_strings) : caller_task_runner_(caller_task_runner), input_task_runner_(input_task_runner), - ui_task_runner_(ui_task_runner) { + ui_task_runner_(ui_task_runner), + ui_strings_(ui_strings) { } BasicDesktopEnvironmentFactory::~BasicDesktopEnvironmentFactory() { |