Readability review.

These CLs implement a simple frame recording and fetch "extension" for the Chromoting protocol, to allow sample sessions to be captured for performance testing.

The three main classes introduced are:
- HostExtensionSessionManager
  This pulls logic for handling Chromoting extensions out of
  ClientSession instances into a dedicated manager class.
  It also introduces hooks through which extensions can
  wrap or replace the Chromoting video encoder or capturer.
- VideoFrameRecorder
  This allows a VideoEncoder to be wrapped to return a new
  encoder that will optionally copy & deliver frames to the
  VideoFrameRecorder before supplying them to the real
  encoder.
- VideoFrameRecorderHostExtension
  This extension uses a VideoFrameRecorder to allow a
  connected client to start/stop recording, and to retrieve
  the resulting frame data.

Original CLs:
crrev.com/402233003
crrev.com/339073002
crrev.com/372943002
crrev.com/462503002

BUG=260879

Review URL: https://codereview.chromium.org/468613002

Cr-Commit-Position: refs/heads/master@{#292541}

1 files changed, 4 insertions, 6 deletions

diff --git a/remoting/host/host_extension_session.cc b/remoting/host/host_extension_session.cc
index 5f54865..c2d8076 100644
--- a/remoting/host/host_extension_session.cc
+++ b/remoting/host/host_extension_session.cc
@@ -9,14 +9,12 @@
 
 namespace remoting {
 
-scoped_ptr<webrtc::DesktopCapturer> HostExtensionSession::OnCreateVideoCapturer(
-    scoped_ptr<webrtc::DesktopCapturer> capturer) {
-  return capturer.Pass();
+void HostExtensionSession::OnCreateVideoCapturer(
+    scoped_ptr<webrtc::DesktopCapturer>* capturer) {
 }
 
-scoped_ptr<VideoEncoder> HostExtensionSession::OnCreateVideoEncoder(
-    scoped_ptr<VideoEncoder> encoder) {
-  return encoder.Pass();
+void HostExtensionSession::OnCreateVideoEncoder(
+    scoped_ptr<VideoEncoder>* encoder) {
 }
 
 bool HostExtensionSession::ModifiesVideoPipeline() const {