diff options
author | ki.stfu <ki.stfu@gmail.com> | 2015-09-21 10:35:51 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-09-21 17:36:27 +0000 |
commit | 35ab93eaa71ba219f60c62e8871a332fc6baa6e8 (patch) | |
tree | dc29d7baae757124421101ae559cedcc8455b0bf /remoting/host | |
parent | d0f29e1666ab81289f7c2cd9390fe3a45b2201dc (diff) | |
download | chromium_src-35ab93eaa71ba219f60c62e8871a332fc6baa6e8.zip chromium_src-35ab93eaa71ba219f60c62e8871a332fc6baa6e8.tar.gz chromium_src-35ab93eaa71ba219f60c62e8871a332fc6baa6e8.tar.bz2 |
Cleanup: Pass std::string as const reference from remoting/
Passing std::string by reference can prevent extra copying of object.
BUG=367418
TEST=
R=joedow@chromium.org,kelvinp@chromium.org
Review URL: https://codereview.chromium.org/1357843002
Cr-Commit-Position: refs/heads/master@{#349952}
Diffstat (limited to 'remoting/host')
-rw-r--r-- | remoting/host/native_messaging/native_messaging_reader_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/remoting/host/native_messaging/native_messaging_reader_unittest.cc b/remoting/host/native_messaging/native_messaging_reader_unittest.cc index 38728b1..4a22ec8 100644 --- a/remoting/host/native_messaging/native_messaging_reader_unittest.cc +++ b/remoting/host/native_messaging/native_messaging_reader_unittest.cc @@ -30,7 +30,7 @@ class NativeMessagingReaderTest : public testing::Test { void OnMessage(scoped_ptr<base::Value> message); // Writes a message (header+body) to the write-end of the pipe. - void WriteMessage(std::string message); + void WriteMessage(const std::string& message); // Writes some data to the write-end of the pipe. void WriteData(const char* data, int length); @@ -74,7 +74,7 @@ void NativeMessagingReaderTest::OnMessage(scoped_ptr<base::Value> message) { message_ = message.Pass(); } -void NativeMessagingReaderTest::WriteMessage(std::string message) { +void NativeMessagingReaderTest::WriteMessage(const std::string& message) { uint32 length = message.length(); WriteData(reinterpret_cast<char*>(&length), 4); WriteData(message.data(), length); |