diff options
| author | sergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-20 23:31:33 +0000 |
|---|---|---|
| committer | sergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-20 23:31:33 +0000 |
| commit | cf988f0ea873f575519ae551c5db5f426b06cc6d (patch) | |
| tree | 9b6fa805b7b042ade23c21f1480696c595117e2c /remoting/jingle_glue/signal_strategy.h | |
| parent | af9d895f38546f9e7c756f77db3d272132e829de (diff) | |
| download | chromium_src-cf988f0ea873f575519ae551c5db5f426b06cc6d.zip chromium_src-cf988f0ea873f575519ae551c5db5f426b06cc6d.tar.gz chromium_src-cf988f0ea873f575519ae551c5db5f426b06cc6d.tar.bz2 | |
Handle IQ responses asynchronously.
Previously IqRequest was calling response callback synchronously. The callback
is allowed to delete SignalStrategy object, but it may be unsafe to delete
XmppSignalStrategy when handling an incoming message. Fixed IqRequest to
invoke response callback asynchronously, so that the callback is called with
a clean stack.
BUG=124430
Review URL: https://chromiumcodereview.appspot.com/10161010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133302 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting/jingle_glue/signal_strategy.h')
| -rw-r--r-- | remoting/jingle_glue/signal_strategy.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/remoting/jingle_glue/signal_strategy.h b/remoting/jingle_glue/signal_strategy.h index 0864cee..8971267 100644 --- a/remoting/jingle_glue/signal_strategy.h +++ b/remoting/jingle_glue/signal_strategy.h @@ -40,7 +40,9 @@ class SignalStrategy { // Called after state of the connection has changed. virtual void OnSignalStrategyStateChange(State state) {} - // Must return true if the stanza was handled, false otherwise. + // Must return true if the stanza was handled, false + // otherwise. The signal strategy must not be deleted from a + // handler of this message. virtual bool OnSignalStrategyIncomingStanza( const buzz::XmlElement* stanza) { return false; } }; |