diff options
| author | sanjeevr@chromium.org <sanjeevr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-30 02:03:35 +0000 |
|---|---|---|
| committer | sanjeevr@chromium.org <sanjeevr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-30 02:03:35 +0000 |
| commit | fd1cd3c589a0ff94d8fbbab949e084ff00bcda5c (patch) | |
| tree | d5ccc22ad732f198ff043928f4c7956874e003f1 /remoting/jingle_glue | |
| parent | abc0e52f70092b4a9035af18f4f01f226c868d27 (diff) | |
| download | chromium_src-fd1cd3c589a0ff94d8fbbab949e084ff00bcda5c.zip chromium_src-fd1cd3c589a0ff94d8fbbab949e084ff00bcda5c.tar.gz chromium_src-fd1cd3c589a0ff94d8fbbab949e084ff00bcda5c.tar.bz2 | |
Called Stop in d'tor of of JingleThread.
It is important to call Stop here. If we wait for the base class to call Stop in it's d'tor, then JingleThread::Run() will access member variables that are already gone. See similar comments in base/thread.h.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9003011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116018 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting/jingle_glue')
| -rw-r--r-- | remoting/jingle_glue/jingle_thread.cc | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/remoting/jingle_glue/jingle_thread.cc b/remoting/jingle_glue/jingle_thread.cc index d31857e..742e3b1 100644 --- a/remoting/jingle_glue/jingle_thread.cc +++ b/remoting/jingle_glue/jingle_thread.cc @@ -144,7 +144,14 @@ JingleThread::JingleThread() message_loop_(NULL) { } -JingleThread::~JingleThread() { } +JingleThread::~JingleThread() { + // It is important to call Stop here. If we wait for the base class to + // call Stop in it's d'tor, then JingleThread::Run() will access member + // variables that are already gone. See similar comments in + // base/threading/thread.h. + if (message_loop_) + Stop(); +} void JingleThread::Start() { Thread::Start(); |