diff options
| author | solb@chromium.org <solb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-09 03:56:44 +0000 |
|---|---|---|
| committer | solb@chromium.org <solb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-09 03:56:44 +0000 |
| commit | 8895ea754b03ca88286805228dd2861346320254 (patch) | |
| tree | 3fec2e40c96d352e678eb02e7164f3f128be4ed4 /remoting/resources | |
| parent | ec640116870dbd130b83c7739ba7691714038d55 (diff) | |
| download | chromium_src-8895ea754b03ca88286805228dd2861346320254.zip chromium_src-8895ea754b03ca88286805228dd2861346320254.tar.gz chromium_src-8895ea754b03ca88286805228dd2861346320254.tar.bz2 | |
Resolve several Chromoting Android UI-related crashes and misbehaviors
This protects several places where the UI once allowed users to hit dangerous edge cases:
- Canceling the auth prompt on the app's first run now leaves the switcher's label text unset.
- Launching the app on a device with no usable accounts once again offers to add a new account.
- Trying to authenticate to an account for the first time while disconnected is detected as a network problem.
- The account switcher is made unavailable when the only usable account is already selected.
- There's a new refresh button for updating the currently-displayed host list from the directory server.
- Pressing a device's extra/exotic buttons with high keycodes no longer DCHECKS to crash the app.
- Many third-party keyboards that stubbornly covered the bottom of the remote desktop image no longer do so.
- All native threads are actually properly detached from the JVM.
BUG=259594
Review URL: https://chromiumcodereview.appspot.com/22662003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216556 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting/resources')
| -rw-r--r-- | remoting/resources/menu/chromoting_actionbar.xml | 4 | ||||
| -rw-r--r-- | remoting/resources/strings.xml | 2 |
2 files changed, 6 insertions, 0 deletions
diff --git a/remoting/resources/menu/chromoting_actionbar.xml b/remoting/resources/menu/chromoting_actionbar.xml index 1507dd4..e602a36 100644 --- a/remoting/resources/menu/chromoting_actionbar.xml +++ b/remoting/resources/menu/chromoting_actionbar.xml @@ -1,6 +1,10 @@ <?xml version="1.0" encoding="utf-8"?> <!--Action bar buttons for the Android app's host listing--> <menu xmlns:android="http://schemas.android.com/apk/res/android"> + <item android:id="@+id/actionbar_directoryrefresh" + android:title="@string/actionbar_directoryrefresh" + android:icon="@android:drawable/ic_popup_sync" + android:showAsAction="ifRoom"/> <item android:id="@+id/actionbar_accountswitcher" android:title="@string/actionbar_accountswitcher" android:icon="@android:drawable/ic_menu_more" diff --git a/remoting/resources/strings.xml b/remoting/resources/strings.xml index 949a2aa..a2c2095 100644 --- a/remoting/resources/strings.xml +++ b/remoting/resources/strings.xml @@ -18,6 +18,7 @@ <string name="pin_entry_cancel">Cancel</string> <!--Action bar buttons--> + <string name="actionbar_directoryrefresh">Refresh</string> <string name="actionbar_accountswitcher">Accounts</string> <string name="actionbar_hide">Hide</string> <string name="actionbar_keyboard">Keyboard</string> @@ -31,6 +32,7 @@ <string name="error_auth_canceled">Authentication prompt canceled by user</string> <string name="error_no_accounts">Device not linked to any Google accounts</string> <string name="error_auth_failed">Authentication with specified account failed</string> + <string name="error_bad_connection">No network connection</string> <string name="error_cataloging_hosts">Unable to display host list</string> <string name="error_displaying_host">Unable to display host entry</string> <string name="error_unexpected_response">Account has no remote desktop hosts registered</string> |