summaryrefslogtreecommitdiffstats
path: root/remoting
diff options
context:
space:
mode:
authorerg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-12-07 23:07:27 +0000
committererg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-12-07 23:07:27 +0000
commitaa20e0622a945f94958daa1940385c29779d09e4 (patch)
tree79ba5e11afb6d6edc5a9e4edef95cca4f86467de /remoting
parent111ca63cacf4cedb65be41fd4cabfa5ad7bb6b86 (diff)
downloadchromium_src-aa20e0622a945f94958daa1940385c29779d09e4.zip
chromium_src-aa20e0622a945f94958daa1940385c29779d09e4.tar.gz
chromium_src-aa20e0622a945f94958daa1940385c29779d09e4.tar.bz2
Move more code from headers to implementation.
BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5624002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68534 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting')
-rw-r--r--remoting/base/compound_buffer.cc2
-rw-r--r--remoting/base/compound_buffer.h1
-rw-r--r--remoting/protocol/rtp_utils.cc22
-rw-r--r--remoting/protocol/rtp_utils.h22
4 files changed, 27 insertions, 20 deletions
diff --git a/remoting/base/compound_buffer.cc b/remoting/base/compound_buffer.cc
index 2808f6d..a766abe 100644
--- a/remoting/base/compound_buffer.cc
+++ b/remoting/base/compound_buffer.cc
@@ -17,6 +17,8 @@ CompoundBuffer::DataChunk::DataChunk(
size(size_value) {
}
+CompoundBuffer::DataChunk::~DataChunk() {}
+
CompoundBuffer::CompoundBuffer()
: total_bytes_(0),
locked_(false) {
diff --git a/remoting/base/compound_buffer.h b/remoting/base/compound_buffer.h
index 1b0a546..eef8d13 100644
--- a/remoting/base/compound_buffer.h
+++ b/remoting/base/compound_buffer.h
@@ -83,6 +83,7 @@ class CompoundBuffer {
struct DataChunk {
DataChunk(net::IOBuffer* buffer, const char* start, int size);
+ ~DataChunk();
scoped_refptr<net::IOBuffer> buffer;
const char* start;
diff --git a/remoting/protocol/rtp_utils.cc b/remoting/protocol/rtp_utils.cc
index 3a6a9340..db04503 100644
--- a/remoting/protocol/rtp_utils.cc
+++ b/remoting/protocol/rtp_utils.cc
@@ -27,6 +27,28 @@ const int kRtcpReceiverReportTotalSize =
const int kRtcpReceiverReportPacketType = 201;
} // namespace
+RtpHeader::RtpHeader()
+ : padding(false),
+ extension(false),
+ sources(0),
+ marker(false),
+ payload_type(0),
+ sequence_number(0),
+ timestamp(0),
+ sync_source_id(0) {
+}
+
+RtcpReceiverReport::RtcpReceiverReport()
+ : receiver_ssrc(0),
+ sender_ssrc(0),
+ loss_fraction(0),
+ total_lost_packets(0),
+ last_sequence_number(0),
+ jitter(0),
+ last_sender_report_timestamp(0),
+ last_sender_report_delay(0) {
+}
+
static inline uint8 ExtractBits(uint8 byte, int bits_count, int shift) {
return (byte >> shift) & ((1 << bits_count) - 1);
}
diff --git a/remoting/protocol/rtp_utils.h b/remoting/protocol/rtp_utils.h
index 599ffaf..4441d78 100644
--- a/remoting/protocol/rtp_utils.h
+++ b/remoting/protocol/rtp_utils.h
@@ -11,16 +11,7 @@ namespace remoting {
namespace protocol {
struct RtpHeader {
- RtpHeader()
- : padding(false),
- extension(false),
- sources(0),
- marker(false),
- payload_type(0),
- sequence_number(0),
- timestamp(0),
- sync_source_id(0) {
- }
+ RtpHeader();
// RTP version is always set to 2.
// version = 2
@@ -36,16 +27,7 @@ struct RtpHeader {
};
struct RtcpReceiverReport {
- RtcpReceiverReport()
- : receiver_ssrc(0),
- sender_ssrc(0),
- loss_fraction(0),
- total_lost_packets(0),
- last_sequence_number(0),
- jitter(0),
- last_sender_report_timestamp(0),
- last_sender_report_delay(0) {
- }
+ RtcpReceiverReport();
uint32 receiver_ssrc;
uint32 sender_ssrc;