summaryrefslogtreecommitdiffstats
path: root/remoting
diff options
context:
space:
mode:
authorfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-28 10:45:50 +0000
committerfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-28 10:45:50 +0000
commit417ed662043bbec5ecc7accbd9ece10a7ff28029 (patch)
tree8bd7f02bfd99ff03fc39b18cefe9004011eadfdc /remoting
parent5ea888129de0660d9afb8e1e348e3081be95ba46 (diff)
downloadchromium_src-417ed662043bbec5ecc7accbd9ece10a7ff28029.zip
chromium_src-417ed662043bbec5ecc7accbd9ece10a7ff28029.tar.gz
chromium_src-417ed662043bbec5ecc7accbd9ece10a7ff28029.tar.bz2
Fix a few uninitialized members in remoting classes.
BUG=None TEST=None CID=15507, 13722, 13617, 13913, 13614. Review URL: http://codereview.chromium.org/6696106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79545 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting')
-rw-r--r--remoting/protocol/connection_to_host.cc6
-rw-r--r--remoting/protocol/protobuf_video_reader.cc5
-rw-r--r--remoting/protocol/rtp_reader.cc8
-rw-r--r--remoting/protocol/rtp_utils.cc3
-rw-r--r--remoting/protocol/rtp_video_reader.cc5
5 files changed, 17 insertions, 10 deletions
diff --git a/remoting/protocol/connection_to_host.cc b/remoting/protocol/connection_to_host.cc
index 59e4001..bdf6f8b 100644
--- a/remoting/protocol/connection_to_host.cc
+++ b/remoting/protocol/connection_to_host.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -33,7 +33,9 @@ ConnectionToHost::ConnectionToHost(
socket_factory_(socket_factory),
port_allocator_session_factory_(session_factory),
event_callback_(NULL),
- dispatcher_(new ClientMessageDispatcher()) {
+ dispatcher_(new ClientMessageDispatcher()),
+ client_stub_(NULL),
+ video_stub_(NULL) {
}
ConnectionToHost::~ConnectionToHost() {
diff --git a/remoting/protocol/protobuf_video_reader.cc b/remoting/protocol/protobuf_video_reader.cc
index a1dc2d2..a2b62388 100644
--- a/remoting/protocol/protobuf_video_reader.cc
+++ b/remoting/protocol/protobuf_video_reader.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -12,7 +12,8 @@ namespace remoting {
namespace protocol {
ProtobufVideoReader::ProtobufVideoReader(VideoPacketFormat::Encoding encoding)
- : encoding_(encoding) {
+ : encoding_(encoding),
+ video_stub_(NULL) {
}
ProtobufVideoReader::~ProtobufVideoReader() { }
diff --git a/remoting/protocol/rtp_reader.cc b/remoting/protocol/rtp_reader.cc
index bee2b98..e99472f 100644
--- a/remoting/protocol/rtp_reader.cc
+++ b/remoting/protocol/rtp_reader.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -13,12 +13,14 @@ namespace protocol {
namespace {
const int kInitialSequenceNumber = -1;
-// Recomended values from RTP spec.
+// Recommended values from RTP spec.
const int kMaxDropout = 3000;
const int kMaxMisorder = 100;
} // namespace
-RtpPacket::RtpPacket() { }
+RtpPacket::RtpPacket()
+ : extended_sequence_number_(0) {
+}
RtpPacket::~RtpPacket() { }
diff --git a/remoting/protocol/rtp_utils.cc b/remoting/protocol/rtp_utils.cc
index db04503..9a56964 100644
--- a/remoting/protocol/rtp_utils.cc
+++ b/remoting/protocol/rtp_utils.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -36,6 +36,7 @@ RtpHeader::RtpHeader()
sequence_number(0),
timestamp(0),
sync_source_id(0) {
+ memset(source_id, 0, sizeof(source_id));
}
RtcpReceiverReport::RtcpReceiverReport()
diff --git a/remoting/protocol/rtp_video_reader.cc b/remoting/protocol/rtp_video_reader.cc
index ad00a4a..a4ae725 100644
--- a/remoting/protocol/rtp_video_reader.cc
+++ b/remoting/protocol/rtp_video_reader.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -22,7 +22,8 @@ RtpVideoReader::PacketsQueueEntry::PacketsQueueEntry()
}
RtpVideoReader::RtpVideoReader()
- : last_sequence_number_(0) {
+ : last_sequence_number_(0),
+ video_stub_(NULL) {
}
RtpVideoReader::~RtpVideoReader() {