summaryrefslogtreecommitdiffstats
path: root/remoting
diff options
context:
space:
mode:
authorlukasza <lukasza@chromium.org>2015-03-12 13:51:32 -0700
committerCommit bot <commit-bot@chromium.org>2015-03-12 20:51:57 +0000
commit5c7cb5077e9e29a2f9b9af42d4879c8448dce7d0 (patch)
treed1fc50724945b81d968b399298b2a060fc43868c /remoting
parent4b0eb6f5d2a81f439328ec73f6666ec28cce3924 (diff)
downloadchromium_src-5c7cb5077e9e29a2f9b9af42d4879c8448dce7d0.zip
chromium_src-5c7cb5077e9e29a2f9b9af42d4879c8448dce7d0.tar.gz
chromium_src-5c7cb5077e9e29a2f9b9af42d4879c8448dce7d0.tar.bz2
Cleaning up Eclipse's warnings.
BUG= Review URL: https://codereview.chromium.org/1003913002 Cr-Commit-Position: refs/heads/master@{#320363}
Diffstat (limited to 'remoting')
-rw-r--r--remoting/android/java/src/org/chromium/chromoting/Chromoting.java4
-rw-r--r--remoting/android/java/src/org/chromium/chromoting/Desktop.java2
-rw-r--r--remoting/android/java/src/org/chromium/chromoting/HostListAdapter.java6
-rw-r--r--remoting/android/javatests/src/org/chromium/chromoting/TapGestureDetectorTest.java8
4 files changed, 5 insertions, 15 deletions
diff --git a/remoting/android/java/src/org/chromium/chromoting/Chromoting.java b/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
index 57dfcb5..8fdd14d 100644
--- a/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
+++ b/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
@@ -382,7 +382,7 @@ public class Chromoting extends ActionBarActivity implements JniInterface.Connec
}
@Override
- public void onItemSelected(AdapterView parent, View view, int itemPosition, long itemId) {
+ public void onItemSelected(AdapterView<?> parent, View view, int itemPosition, long itemId) {
mAccount = mAccounts[itemPosition];
getPreferences(MODE_PRIVATE).edit().putString("account_name", mAccount.name)
@@ -395,7 +395,7 @@ public class Chromoting extends ActionBarActivity implements JniInterface.Connec
}
@Override
- public void onNothingSelected(AdapterView parent) {
+ public void onNothingSelected(AdapterView<?> parent) {
}
@Override
diff --git a/remoting/android/java/src/org/chromium/chromoting/Desktop.java b/remoting/android/java/src/org/chromium/chromoting/Desktop.java
index 7135492..a121c40 100644
--- a/remoting/android/java/src/org/chromium/chromoting/Desktop.java
+++ b/remoting/android/java/src/org/chromium/chromoting/Desktop.java
@@ -178,7 +178,7 @@ public class Desktop extends ActionBarActivity implements View.OnSystemUiVisibil
}
/** The overlay button's onClick handler. */
- public void onOverlayButtonPressed(View view) {
+ public void onOverlayButtonPressed(@SuppressWarnings("unused") View view) {
showActionBar();
}
diff --git a/remoting/android/java/src/org/chromium/chromoting/HostListAdapter.java b/remoting/android/java/src/org/chromium/chromoting/HostListAdapter.java
index cf76388..c7d826e 100644
--- a/remoting/android/java/src/org/chromium/chromoting/HostListAdapter.java
+++ b/remoting/android/java/src/org/chromium/chromoting/HostListAdapter.java
@@ -12,12 +12,6 @@ import android.widget.Toast;
/** Describes the appearance and behavior of each host list entry. */
class HostListAdapter extends ArrayAdapter<HostInfo> {
- /** Color to use for hosts that are online. */
- private static final String HOST_COLOR_ONLINE = "green";
-
- /** Color to use for hosts that are offline. */
- private static final String HOST_COLOR_OFFLINE = "red";
-
private Chromoting mChromoting;
/** Constructor. */
diff --git a/remoting/android/javatests/src/org/chromium/chromoting/TapGestureDetectorTest.java b/remoting/android/javatests/src/org/chromium/chromoting/TapGestureDetectorTest.java
index a7a392f..ab66faa 100644
--- a/remoting/android/javatests/src/org/chromium/chromoting/TapGestureDetectorTest.java
+++ b/remoting/android/javatests/src/org/chromium/chromoting/TapGestureDetectorTest.java
@@ -31,12 +31,6 @@ public class TapGestureDetectorTest extends InstrumentationTestCase {
mLongPressCount = pointerCount;
}
- /** Resets the mock listener to its initial state. */
- public void reset() {
- mTapCount = -1;
- mLongPressCount = -1;
- }
-
public void assertTapDetected(int expectedCount) {
assertEquals(expectedCount, mTapCount);
assertEquals(-1, mLongPressCount);
@@ -155,6 +149,7 @@ public class TapGestureDetectorTest extends InstrumentationTestCase {
@Feature({"Chromoting"})
public void testLongPress() throws Exception {
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ @Override
public void run() {
// Ensure the gesture-detector is created on the UI thread, so that it uses the
// Handler for the UI thread for LongPress notifications.
@@ -168,6 +163,7 @@ public class TapGestureDetectorTest extends InstrumentationTestCase {
Thread.sleep(2 * ViewConfiguration.getLongPressTimeout());
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ @Override
public void run() {
injectUpEvent(0);
}