diff options
| author | sdefresne <sdefresne@chromium.org> | 2015-07-16 01:34:35 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-16 08:35:10 +0000 |
| commit | d967d55cf7a0f78e6ace9ec681d2d082e631810b (patch) | |
| tree | 09139d0dae0027b25dd3f06637e663d4cad173eb /rlz/test | |
| parent | 835f5b61c251e60088256d952188632d2d671cba (diff) | |
| download | chromium_src-d967d55cf7a0f78e6ace9ec681d2d082e631810b.zip chromium_src-d967d55cf7a0f78e6ace9ec681d2d082e631810b.tar.gz chromium_src-d967d55cf7a0f78e6ace9ec681d2d082e631810b.tar.bz2 | |
Componentize chrome/browser/rlz
Add new class RLZTrackerDelegate that abstract access to embedder
specific singletons and informations and provide an implementation for
Chrome based on the previous implementation.
Split rlz_unittest.cc in tests of the RLZTracker and Chrome
implementation of the RLZTrackerDelegate interface and move the
RLZTracker tests into the component.
Add a new gyp/gn variable "enable_rlz_support". This variable is true on
the platforms that support RLZ (currently Windows, Mac, iOS and
ChromeOS). Use it to build library and unit tests even when the RLZ
support is not enabled in the Chrome binary (this is still controlled by
"enable_rlz" and depends on the branding).
Enable the tests on iOS and convert rlz_tracker_ios.mm to a C++ file.
TEST=Run unit_tests and components_unittests on a platform that supports
RLZ (Windows, Mac, iOS or ChromeOS) and check that they pass. Then build
Chrome with "enable_rlz" and manually checks that RLZ are sent with
searches as expected.
BUG=504841,508148
Review URL: https://codereview.chromium.org/1212163011
Cr-Commit-Position: refs/heads/master@{#339002}
Diffstat (limited to 'rlz/test')
| -rw-r--r-- | rlz/test/rlz_test_helpers.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rlz/test/rlz_test_helpers.h b/rlz/test/rlz_test_helpers.h index c02aadc..7d24e62 100644 --- a/rlz/test/rlz_test_helpers.h +++ b/rlz/test/rlz_test_helpers.h @@ -19,7 +19,7 @@ #endif // A test helper class that constructs and destructs platform dependent machine -// state. It's used by src/chrome/browser/rlz/rlz_unittest.cc and +// state. It's used by src/components/rlz/rlz_tracker_unittest.cc and // src/rlz/lib/rlz_lib_test.cc class RlzLibTestNoMachineStateHelper { public: |