summaryrefslogtreecommitdiffstats
path: root/sandbox/sandbox.gyp
diff options
context:
space:
mode:
authorbenjhayden@chromium.org <benjhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-21 19:43:42 +0000
committerbenjhayden@chromium.org <benjhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-21 19:43:42 +0000
commitb62972dac61add19354116b5549ba624b982f14f (patch)
treedd85ab59beed03f5ea943994d75023a955581790 /sandbox/sandbox.gyp
parent8a53de29a127aade966d8473d3bdbe48a7416f04 (diff)
downloadchromium_src-b62972dac61add19354116b5549ba624b982f14f.zip
chromium_src-b62972dac61add19354116b5549ba624b982f14f.tar.gz
chromium_src-b62972dac61add19354116b5549ba624b982f14f.tar.bz2
Move chrome.downloads out of experimental to dev
Owners breakdown: aa (LG'd): chrome/browser/extensions/*, chrome/common/extensions/extension_permission_set mkearney: New docs are staged in https://www/~benjhayden/no_crawl/downloads_docs/downloads.html (sorry, only available inside Google) everybody else: feel free to review or remove yourself as you wish Currently implemented and documented: download(), search(), pause(), resume(), cancel(), getFileIcon(), onCreated, onChanged, onErased. Move the implementation from chrome/browser/download to chrome/browser/extensions/api/downloads in preparation for using json_schema_compiler. Restrict chrome.downloads to the dev channel. Rewrite download() to use DownloadManager/DownloadUrlParameters. Remove "headers[].binaryValue". UTF16 has the same code-point range as UTF8, is less standard, and a PITA in general. There are javascript solutions to converting UTF16->UTF8 and ArrayBuffer->string if an extension really needs it. I can't imagine a situation where an extension would need to pass an ArrayBuffer directly to download(), but if one arises then there are multiple backward-compatible solutions. Fix ExtensionDownloadsEventRouter in incognito. Rename DownloadDelta fields from 'old'/'new' to 'previous'/'current'. 'new' is frequently a reserved keyword, so even if the IDL parser accepted it and translated '_new' to 'new', it would still be highlighted confusingly in developers' editors. OnChanged was never publicly documented, so this should not affect anything but my test.js. Remove the properties from the API. The platform is moving away from #defines such as those. The json_schema_compiler doesn't even support them. It's just easier to type 'complete' than chrome.downloads.STATE_COMPLETE, and those strings (besides the errors) were never going to change, anyway. I got tired of merging a very long line in api_index.html, so I added a newline in static/api_index.html. TODO(benjhayden): Test download() and ExtensionDownloadsEventRouter in incognito. See WIP http://codereview.chromium.org/10542038/ BUG=117014,87436 Review URL: https://chromiumcodereview.appspot.com/9617010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143432 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sandbox/sandbox.gyp')
0 files changed, 0 insertions, 0 deletions