diff options
author | cpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-20 01:27:20 +0000 |
---|---|---|
committer | cpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-20 01:27:20 +0000 |
commit | af1e6f59e12fabc8ae8ab1fbb0f0423e42dfadf2 (patch) | |
tree | d8e2d84f8b6baeb4bcf7e44cc9f2dcf73bcfbcaf /sandbox/src/crosscall_params.h | |
parent | 0c5970256ba27bbc97d03586646c5931374188ca (diff) | |
download | chromium_src-af1e6f59e12fabc8ae8ab1fbb0f0423e42dfadf2.zip chromium_src-af1e6f59e12fabc8ae8ab1fbb0f0423e42dfadf2.tar.gz chromium_src-af1e6f59e12fabc8ae8ab1fbb0f0423e42dfadf2.tar.bz2 |
Revert 56796 - Sbox IPC fix
Tests failing on vista
BUG=52682
TEST=included
Review URL: http://codereview.chromium.org/3142022
TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/3122031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56798 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sandbox/src/crosscall_params.h')
-rw-r--r-- | sandbox/src/crosscall_params.h | 51 |
1 files changed, 20 insertions, 31 deletions
diff --git a/sandbox/src/crosscall_params.h b/sandbox/src/crosscall_params.h index 4c1e4fe..939925c 100644 --- a/sandbox/src/crosscall_params.h +++ b/sandbox/src/crosscall_params.h @@ -169,33 +169,30 @@ class CrossCallParams { // blob to be complex. // // As is, this class assumes that the layout of the blob is as follows. Assume -// that NUMBER_PARAMS = 2 and a 32-bit build: +// that NUMBER_PARAMS = 2: // -// [ tag 4 bytes] -// [ IsOnOut 4 bytes] -// [ call return 52 bytes] -// [ params count 4 bytes] -// [ parameter 0 type 4 bytes] -// [ parameter 0 offset 4 bytes] ---delta to ---\ -// [ parameter 0 size 4 bytes] | -// [ parameter 1 type 4 bytes] | -// [ parameter 1 offset 4 bytes] ---------------|--\ -// [ parameter 1 size 4 bytes] | | -// [ parameter 2 type 4 bytes] | | -// [ parameter 2 offset 4 bytes] ----------------------\ -// [ parameter 2 size 4 bytes] | | | -// |---------------------------| | | | -// | value 0 (x bytes) | <--------------/ | | -// | value 1 (y bytes) | <-----------------/ | -// | | | -// | end of buffer | <---------------------/ -// |---------------------------| +// [ tag 4 bytes] +// [ IsOnOut 4 bytes] +// [ call return 52 bytes] +// [ params count 4 bytes] +// [ parameter 0 type 4 bytes] +// [ parameter 0 /\ 4 bytes] ---delta to ---\ +// [ parameter 0 size 4 bytes] | +// [ parameter 1 type 4 bytes] | +// [ parameter 1 /\ 4 bytes] | +// [ parameter 1 size 4 bytes] | +// [ parameter 2 type 4 bytes] | +// [ parameter 2 /\ 4 bytes] ----------------------\ +// [ parameter 2 size 4 bytes] | | +// |-------------------------| | | +// | | <--------------/ | +// | | | +// | | <---------------------/ +// |-------------------------| // // Note that the actual number of params is NUMBER_PARAMS + 1 // so that the size of each actual param can be computed from the difference -// between one parameter and the next down. The offset of the last param -// points to the end of the buffer and the type and size are undefined. -// +// between one parameter and the next down template <size_t NUMBER_PARAMS, size_t BLOCK_SIZE> class ActualCallParams : public CrossCallParams { public: @@ -212,14 +209,6 @@ class ActualCallParams : public CrossCallParams { param_info_[0].offset_ = parameters_ - reinterpret_cast<char*>(this); } - // Testing-only method. Allows setting the apparent size to a wrong value. - // returns the previous size. - size_t OverrideSize(size_t new_size) { - size_t previous_size = param_info_[NUMBER_PARAMS].offset_; - param_info_[NUMBER_PARAMS].offset_ = new_size; - return previous_size; - } - // Copies each paramter into the internal buffer. For each you must supply: // index: 0 for the first param, 1 for the next an so on bool CopyParamIn(size_t index, const void* parameter_address, size_t size, |