diff options
| author | cpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-08 21:29:43 +0000 |
|---|---|---|
| committer | cpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-08 21:29:43 +0000 |
| commit | df91e5742b0e11bda7e605167d0f5554ab27dcf3 (patch) | |
| tree | 86a4b3df2da00bca8fe74a9eb31819159c0984a2 /sandbox/src/crosscall_server.h | |
| parent | f460cc8c601dc33138e32a94a2285ab9c587a7a0 (diff) | |
| download | chromium_src-df91e5742b0e11bda7e605167d0f5554ab27dcf3.zip chromium_src-df91e5742b0e11bda7e605167d0f5554ab27dcf3.tar.gz chromium_src-df91e5742b0e11bda7e605167d0f5554ab27dcf3.tar.bz2 | |
Klocwork bug. The dtor of Win2kThreadpool needs to be virtual since
the object is destroyed thru the base.
- Removed UnRegisterWait loop in dtor.
BUG=3108
Review URL: http://codereview.chromium.org/6247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3057 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sandbox/src/crosscall_server.h')
| -rw-r--r-- | sandbox/src/crosscall_server.h | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/sandbox/src/crosscall_server.h b/sandbox/src/crosscall_server.h index fdd2177..9d2052f 100644 --- a/sandbox/src/crosscall_server.h +++ b/sandbox/src/crosscall_server.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef SANDBOX_SRC_CROSSCALL_SERVER_H__ -#define SANDBOX_SRC_CROSSCALL_SERVER_H__ +#ifndef SANDBOX_SRC_CROSSCALL_SERVER_H_ +#define SANDBOX_SRC_CROSSCALL_SERVER_H_ #include <string> #include <vector> @@ -78,6 +78,7 @@ class ThreadProvider { // Removes all the registrations done with the same cookie parameter. // This frees internal thread pool resources. virtual bool UnRegisterWaits(void* cookie) = 0; + virtual ~ThreadProvider() {} }; // Models the server-side of the original input parameters. @@ -120,7 +121,7 @@ class CrossCallParamsEx : public CrossCallParams { CrossCallParamsEx(); ParamInfo param_info_[1]; - DISALLOW_EVIL_CONSTRUCTORS(CrossCallParamsEx); + DISALLOW_COPY_AND_ASSIGN(CrossCallParamsEx); }; // Simple helper function that sets the members of CrossCallReturn @@ -214,5 +215,5 @@ class Dispatcher { } // namespace sandbox -#endif // SANDBOX_SRC_CROSSCALL_SERVER_H__ +#endif // SANDBOX_SRC_CROSSCALL_SERVER_H_ |