diff options
| author | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 20:21:16 +0000 |
|---|---|---|
| committer | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 20:21:16 +0000 |
| commit | bd635c097dfc689674d6b21c006850a7b07f23f4 (patch) | |
| tree | b9c8bdf9edc379e288c14f64e063e29efe7635c8 /sandbox/src/restricted_token_unittest.cc | |
| parent | 19dc5d7922dc07b61c037ebbcc86f20dad27eab2 (diff) | |
| download | chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.zip chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.tar.gz chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.tar.bz2 | |
Enable warning 4389 as an error on windows builds. This will make
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2081007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sandbox/src/restricted_token_unittest.cc')
| -rw-r--r-- | sandbox/src/restricted_token_unittest.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sandbox/src/restricted_token_unittest.cc b/sandbox/src/restricted_token_unittest.cc index d8fe233..310b73f 100644 --- a/sandbox/src/restricted_token_unittest.cc +++ b/sandbox/src/restricted_token_unittest.cc @@ -23,11 +23,11 @@ TEST(RestrictedTokenTest, InvalidHandle) { // Tests the initialization with NULL as parameter. TEST(RestrictedTokenTest, DefaultInit) { // Get the current process token. - HANDLE token_handle = NULL; + HANDLE token_handle = INVALID_HANDLE_VALUE; ASSERT_TRUE(::OpenProcessToken(::GetCurrentProcess(), TOKEN_ALL_ACCESS, &token_handle)); - ASSERT_NE(NULL, reinterpret_cast<ULONG_PTR>(token_handle)); + ASSERT_NE(INVALID_HANDLE_VALUE, token_handle); ATL::CAccessToken access_token; access_token.Attach(token_handle); @@ -62,11 +62,11 @@ TEST(RestrictedTokenTest, DefaultInit) { // Tests the initialization with a custom token as parameter. TEST(RestrictedTokenTest, CustomInit) { // Get the current process token. - HANDLE token_handle = NULL; + HANDLE token_handle = INVALID_HANDLE_VALUE; ASSERT_TRUE(::OpenProcessToken(::GetCurrentProcess(), TOKEN_ALL_ACCESS, &token_handle)); - ASSERT_NE(NULL, reinterpret_cast<ULONG_PTR>(token_handle)); + ASSERT_NE(INVALID_HANDLE_VALUE, token_handle); ATL::CAccessToken access_token; access_token.Attach(token_handle); |