diff options
| author | cpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-08 21:29:43 +0000 |
|---|---|---|
| committer | cpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-08 21:29:43 +0000 |
| commit | df91e5742b0e11bda7e605167d0f5554ab27dcf3 (patch) | |
| tree | 86a4b3df2da00bca8fe74a9eb31819159c0984a2 /sandbox/src/win2k_threadpool.cc | |
| parent | f460cc8c601dc33138e32a94a2285ab9c587a7a0 (diff) | |
| download | chromium_src-df91e5742b0e11bda7e605167d0f5554ab27dcf3.zip chromium_src-df91e5742b0e11bda7e605167d0f5554ab27dcf3.tar.gz chromium_src-df91e5742b0e11bda7e605167d0f5554ab27dcf3.tar.bz2 | |
Klocwork bug. The dtor of Win2kThreadpool needs to be virtual since
the object is destroyed thru the base.
- Removed UnRegisterWait loop in dtor.
BUG=3108
Review URL: http://codereview.chromium.org/6247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3057 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sandbox/src/win2k_threadpool.cc')
| -rw-r--r-- | sandbox/src/win2k_threadpool.cc | 18 |
1 files changed, 4 insertions, 14 deletions
diff --git a/sandbox/src/win2k_threadpool.cc b/sandbox/src/win2k_threadpool.cc index e25c904..296ec379 100644 --- a/sandbox/src/win2k_threadpool.cc +++ b/sandbox/src/win2k_threadpool.cc @@ -56,19 +56,9 @@ size_t Win2kThreadPool::OutstandingWaits() { } Win2kThreadPool::~Win2kThreadPool() { - // time to close all the pool wait handles. This frees the thread pool so - // it can throttle down the number of 'ready' threads. - AutoLock lock(&lock_); - PoolObjects::iterator it; - for (it = pool_objects_.begin(); it != pool_objects_.end(); ++it) { - if (0 != it->cookie) { - if (FALSE == ::UnregisterWait(it->wait)) { - NOTREACHED(); - } - it->cookie = 0; - } - } + // Here we used to unregister all the pool wait handles. Now, following the + // rest of the code we avoid lengthy or blocking calls given that the process + // is being torn down. } -} // namespace sandbox - +} // namespace sandbox
\ No newline at end of file |