diff options
| author | cpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-08 21:29:43 +0000 |
|---|---|---|
| committer | cpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-08 21:29:43 +0000 |
| commit | df91e5742b0e11bda7e605167d0f5554ab27dcf3 (patch) | |
| tree | 86a4b3df2da00bca8fe74a9eb31819159c0984a2 /sandbox/src/win2k_threadpool.h | |
| parent | f460cc8c601dc33138e32a94a2285ab9c587a7a0 (diff) | |
| download | chromium_src-df91e5742b0e11bda7e605167d0f5554ab27dcf3.zip chromium_src-df91e5742b0e11bda7e605167d0f5554ab27dcf3.tar.gz chromium_src-df91e5742b0e11bda7e605167d0f5554ab27dcf3.tar.bz2 | |
Klocwork bug. The dtor of Win2kThreadpool needs to be virtual since
the object is destroyed thru the base.
- Removed UnRegisterWait loop in dtor.
BUG=3108
Review URL: http://codereview.chromium.org/6247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3057 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sandbox/src/win2k_threadpool.h')
| -rw-r--r-- | sandbox/src/win2k_threadpool.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/sandbox/src/win2k_threadpool.h b/sandbox/src/win2k_threadpool.h index 0b0a319..81c6d10 100644 --- a/sandbox/src/win2k_threadpool.h +++ b/sandbox/src/win2k_threadpool.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef SANDBOX_SRC_WIN2K_THREADPOOL_H__ -#define SANDBOX_SRC_WIN2K_THREADPOOL_H__ +#ifndef SANDBOX_SRC_WIN2K_THREADPOOL_H_ +#define SANDBOX_SRC_WIN2K_THREADPOOL_H_ #include <list> #include <algorithm> @@ -27,7 +27,7 @@ class Win2kThreadPool : public ThreadProvider { Win2kThreadPool() { ::InitializeCriticalSection(&lock_); } - ~Win2kThreadPool(); + virtual ~Win2kThreadPool(); virtual bool RegisterWait(const void* client, HANDLE waitable_object, CrossCallIPCCallback callback, @@ -50,10 +50,10 @@ class Win2kThreadPool : public ThreadProvider { PoolObjects pool_objects_; // This lock protects the list of pool wait objects. CRITICAL_SECTION lock_; - DISALLOW_EVIL_CONSTRUCTORS(Win2kThreadPool); + DISALLOW_COPY_AND_ASSIGN(Win2kThreadPool); }; } // namespace sandbox -#endif // SANDBOX_SRC_WIN2K_THREADPOOL_H__ +#endif // SANDBOX_SRC_WIN2K_THREADPOOL_H_ |