diff options
author | dimich@chromium.org <dimich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-03 02:29:44 +0000 |
---|---|---|
committer | dimich@chromium.org <dimich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-03 02:29:44 +0000 |
commit | 42ff2c813339961af8e09a372979a7bf7be77a5d (patch) | |
tree | 381f151ecfb89b32eedb6b935cb8367b4c2db450 /sandbox/src | |
parent | 6dd32575d4dfdf75d86ba8726850c98bcbcec9e3 (diff) | |
download | chromium_src-42ff2c813339961af8e09a372979a7bf7be77a5d.zip chromium_src-42ff2c813339961af8e09a372979a7bf7be77a5d.tar.gz chromium_src-42ff2c813339961af8e09a372979a7bf7be77a5d.tar.bz2 |
Landing for dbelenko.
Fix for bug 28646: Implement LayoutTestController.dumpSelectionRect()
This fix will prepare the test cases affected by bug 28646 for rebaseline.
It does three things:
1. Implements dumpSelectionRect() and the related drawing code.
2. Marks the affected test cases as FAIL and removes platform restrictions
for them from test_expectations.txt
3. Marks three new test cases as FAIL. These test cases have incorrect
baseline images. I have contacted the authors and got an OK from them to
rebaseline the expected image.
After this is committed, I will retrieve the images from the buildbot and
rebaseline the expectations for the affected test cases.
Trybot runs for this patch:
http://build.chromium.org/buildbot/try-server/builders/layout_linux/builds/1477
http://build.chromium.org/buildbot/try-server/builders/layout_win/builds/1478
http://build.chromium.org/buildbot/try-server/builders/layout_mac/builds/1341
BUG=28646
TEST=This change will enable over 30 tests on all three platforms. I have
inspected the images visually, the rect gets drawn correctly, in the same
locations as in WebKit tests, but with a slightly different color, due to
differences in Skia rasterization and alpha blending. These differences
are not critical to the purpose of the test cases.
Review URL: http://codereview.chromium.org/661437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40484 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sandbox/src')
0 files changed, 0 insertions, 0 deletions