summaryrefslogtreecommitdiffstats
path: root/sandbox/tests
diff options
context:
space:
mode:
authorjcivelli@chromium.org <jcivelli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-26 00:06:11 +0000
committerjcivelli@chromium.org <jcivelli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-26 00:06:11 +0000
commit9253d5742880d6ed01704874b7b89e8fbf800c5e (patch)
tree7ef1d9e5c2611c6cac2b30fbeb52bdc0729b35d8 /sandbox/tests
parentf6ebf0766ca2e0a39d0831dfda8e8fd755c8b722 (diff)
downloadchromium_src-9253d5742880d6ed01704874b7b89e8fbf800c5e.zip
chromium_src-9253d5742880d6ed01704874b7b89e8fbf800c5e.tar.gz
chromium_src-9253d5742880d6ed01704874b7b89e8fbf800c5e.tar.bz2
TranslateInfoBarDelegate2 were leaked. (Yikes!)
This revealed that the NormalTranslate unit-test was incorrect (it was not testing that changing the source or target language from the after translate infobar causes a translation). This also revealed that returning reference string in the delegate is not a brilliant idea as when we switch infobars, the new infobar might be using a string from the old infobar that might have been deleted. BUG=None TEST=Linux heap check bot should be green. Review URL: http://codereview.chromium.org/2822032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50913 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sandbox/tests')
0 files changed, 0 insertions, 0 deletions