diff options
| author | phoglund <phoglund@chromium.org> | 2015-12-18 01:24:23 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-18 09:25:19 +0000 |
| commit | 666f25fff59502a70563a63e9b848d03fc547fde (patch) | |
| tree | 73549fcd256c427994e243ea3e4186eccb4b32fd /sandbox/win | |
| parent | a9f7ec25e3ec1d2c6c56fc0a8ce28980c1412d66 (diff) | |
| download | chromium_src-666f25fff59502a70563a63e9b848d03fc547fde.zip chromium_src-666f25fff59502a70563a63e9b848d03fc547fde.tar.gz chromium_src-666f25fff59502a70563a63e9b848d03fc547fde.tar.bz2 | |
Revert of Make base a static ibrary (patchset #3 id:40001 of https://codereview.chromium.org/1528233002/ )
Reason for revert:
Breaks Win GN link:
unresolved external symbol JSONFileValueDeserializer::JSONFileValueDeserializer ... referenced in function "class JsonPrefStore::ReadResult> > __cdecl `anonymous namespace'::ReadPrefsFromDisk ...
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/15424/steps/compile/logs/stdio
Original issue's description:
> Make base a static ibrary
>
> This saves a nontrivial amount of space for some of the smaller targets in release builds. See the comment added to the base target for more.
>
> Remove libmojo_sdk. This is a complete static library that depended on base. Since base is now a static library, this dependency is not allowed. The mojo team says this target is no longer needed, so it was deleted.
>
> Committed: https://crrev.com/89c7be623e3cc5052aaf8c3be3996432a9d4bceb
> Cr-Commit-Position: refs/heads/master@{#365955}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1532953003
Cr-Commit-Position: refs/heads/master@{#366062}
Diffstat (limited to 'sandbox/win')
| -rw-r--r-- | sandbox/win/BUILD.gn | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/sandbox/win/BUILD.gn b/sandbox/win/BUILD.gn index 327396b..4d1dd58 100644 --- a/sandbox/win/BUILD.gn +++ b/sandbox/win/BUILD.gn @@ -4,11 +4,7 @@ import("//testing/test.gni") -# This needs to be a static library rather than a sources set because small -# portions of this are used in some contexts (like chrome_elf), and it -# doesnn't seem to dead-code strip very well. This saves 12K on chrome_elf.dll, -# over a source set, for example. -static_library("sandbox") { +source_set("sandbox") { sources = [ "src/acl.cc", "src/acl.h", |