diff options
| author | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-19 00:06:09 +0000 |
|---|---|---|
| committer | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-19 00:06:09 +0000 |
| commit | cf09fc816bd23ba0a196ac7aa032b99eed0a63b3 (patch) | |
| tree | 0af98fe48d236664faf9238bf6f6c213ddd43287 /sandbox | |
| parent | c35d0206b2ad1b9004d07d25e615ce80c22b72eb (diff) | |
| download | chromium_src-cf09fc816bd23ba0a196ac7aa032b99eed0a63b3.zip chromium_src-cf09fc816bd23ba0a196ac7aa032b99eed0a63b3.tar.gz chromium_src-cf09fc816bd23ba0a196ac7aa032b99eed0a63b3.tar.bz2 | |
I'm removing logging.h/.cc from wow_helper.
We were using it for only 2 small DCHECKs, but now
logging.h depends on a lot of other stuff in base, and
it's a lot of work to port everything back in wow_helper
(icu?)
I don't think it's worth the trouble for only 2 dchecks.
Review URL: http://codereview.chromium.org/11603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5650 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sandbox')
| -rw-r--r-- | sandbox/wow_helper/service64_resolver.cc | 2 | ||||
| -rw-r--r-- | sandbox/wow_helper/wow_helper.cc | 2 | ||||
| -rw-r--r-- | sandbox/wow_helper/wow_helper.vcproj | 8 |
3 files changed, 0 insertions, 12 deletions
diff --git a/sandbox/wow_helper/service64_resolver.cc b/sandbox/wow_helper/service64_resolver.cc index 3c70e24..91a6716 100644 --- a/sandbox/wow_helper/service64_resolver.cc +++ b/sandbox/wow_helper/service64_resolver.cc @@ -4,7 +4,6 @@ #include "sandbox/wow_helper/service64_resolver.h" -#include "base/logging.h" #include "base/scoped_ptr.h" #include "sandbox/wow_helper/target_code.h" @@ -241,7 +240,6 @@ NTSTATUS Service64ResolverThunk::ResolveInterceptor( NTSTATUS Service64ResolverThunk::ResolveTarget(const void* module, const char* function_name, void** address) { - DCHECK(address); if (NULL == module) return STATUS_UNSUCCESSFUL; diff --git a/sandbox/wow_helper/wow_helper.cc b/sandbox/wow_helper/wow_helper.cc index 170b4f9..a51cfe7 100644 --- a/sandbox/wow_helper/wow_helper.cc +++ b/sandbox/wow_helper/wow_helper.cc @@ -12,7 +12,6 @@ #include <string> -#include "base/logging.h" #include "sandbox/wow_helper/service64_resolver.h" #include "sandbox/wow_helper/target_code.h" @@ -112,7 +111,6 @@ int wWinMain(HINSTANCE, HINSTANCE, wchar_t* command_line, int) { DWORD access = PROCESS_VM_OPERATION | PROCESS_VM_READ | PROCESS_VM_WRITE; HANDLE child = ::OpenProcess(access, FALSE, process_id); - DCHECK(child); if (!child) return 3; diff --git a/sandbox/wow_helper/wow_helper.vcproj b/sandbox/wow_helper/wow_helper.vcproj index 3fef097..7a2d8c6 100644 --- a/sandbox/wow_helper/wow_helper.vcproj +++ b/sandbox/wow_helper/wow_helper.vcproj @@ -181,14 +181,6 @@ Name="base" > <File - RelativePath="..\..\base\logging.cc" - > - </File> - <File - RelativePath="..\..\base\logging.h" - > - </File> - <File RelativePath="..\..\base\scoped_ptr.h" > </File> |