summaryrefslogtreecommitdiffstats
path: root/sandbox
diff options
context:
space:
mode:
authorglider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-10 08:33:42 +0000
committerglider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-10 08:33:42 +0000
commit8e30016059eda2023b62a38563c406a7bc042040 (patch)
treec67d420c8a41d00101b81beb8a533119c9028bd4 /sandbox
parentead6b43b59c5de3642fa4ab89c74b6fd2ac719a4 (diff)
downloadchromium_src-8e30016059eda2023b62a38563c406a7bc042040.zip
chromium_src-8e30016059eda2023b62a38563c406a7bc042040.tar.gz
chromium_src-8e30016059eda2023b62a38563c406a7bc042040.tar.bz2
Disable the failing ThreadHelpers.* tests under ThreadSanitizer for now.
BUG=342305 TBR=jln@chromium.org Review URL: https://codereview.chromium.org/158703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250062 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sandbox')
-rw-r--r--sandbox/linux/services/thread_helpers_unittests.cc17
1 files changed, 14 insertions, 3 deletions
diff --git a/sandbox/linux/services/thread_helpers_unittests.cc b/sandbox/linux/services/thread_helpers_unittests.cc
index 725a62e..ec7e445 100644
--- a/sandbox/linux/services/thread_helpers_unittests.cc
+++ b/sandbox/linux/services/thread_helpers_unittests.cc
@@ -50,7 +50,18 @@ class ScopedProcSelfTask {
DISALLOW_COPY_AND_ASSIGN(ScopedProcSelfTask);
};
-TEST(ThreadHelpers, IsSingleThreadedBasic) {
+#if defined(THREAD_SANITIZER)
+// These tests fail under ThreadSanitizer, see http://crbug.com/342305
+#define MAYBE_IsSingleThreadedBasic DISABLED_IsSingleThreadedBasic
+#define MAYBE_IsSingleThreadedIterated DISABLED_IsSingleThreadedIterated
+#define MAYBE_IsSingleThreadedStartAndStop DISABLED_IsSingleThreadedStartAndStop
+#else
+#define MAYBE_IsSingleThreadedBasic IsSingleThreadedBasic
+#define MAYBE_IsSingleThreadedIterated IsSingleThreadedIterated
+#define MAYBE_IsSingleThreadedStartAndStop IsSingleThreadedStartAndStop
+#endif
+
+TEST(ThreadHelpers, MAYBE_IsSingleThreadedBasic) {
ScopedProcSelfTask task;
ASSERT_TRUE(ThreadHelpers::IsSingleThreaded(task.fd()));
@@ -59,7 +70,7 @@ TEST(ThreadHelpers, IsSingleThreadedBasic) {
ASSERT_FALSE(ThreadHelpers::IsSingleThreaded(task.fd()));
}
-TEST(ThreadHelpers, IsSingleThreadedIterated) {
+TEST(ThreadHelpers, MAYBE_IsSingleThreadedIterated) {
ScopedProcSelfTask task;
ASSERT_TRUE(ThreadHelpers::IsSingleThreaded(task.fd()));
@@ -71,7 +82,7 @@ TEST(ThreadHelpers, IsSingleThreadedIterated) {
}
}
-TEST(ThreadHelpers, IsSingleThreadedStartAndStop) {
+TEST(ThreadHelpers, MAYBE_IsSingleThreadedStartAndStop) {
ScopedProcSelfTask task;
ASSERT_TRUE(ThreadHelpers::IsSingleThreaded(task.fd()));