summaryrefslogtreecommitdiffstats
path: root/sdch/BUILD.gn
diff options
context:
space:
mode:
authorshrike <shrike@chromium.org>2015-04-15 10:42:55 -0700
committerCommit bot <commit-bot@chromium.org>2015-04-15 17:43:25 +0000
commit3d0f62159e9655f42bbdb80dae29f0e2d40db0c9 (patch)
tree4225bc306a240f3ab996602f4e6218da2d87f444 /sdch/BUILD.gn
parenta460cbb69ccd575bb70ec36874a13f802fabe429 (diff)
downloadchromium_src-3d0f62159e9655f42bbdb80dae29f0e2d40db0c9.zip
chromium_src-3d0f62159e9655f42bbdb80dae29f0e2d40db0c9.tar.gz
chromium_src-3d0f62159e9655f42bbdb80dae29f0e2d40db0c9.tar.bz2
Prevent bookmarks bar toggling from decreasing window height to 0.
Toggling the bookmarks bar changes the height of the browser window when viewing a regular web page but does not change its height when viewing a NTP. As a result, it is possible for the browser window to creep taller or shorter with the right sequence of steps. When the browser window gets shorter, it's possible to decrease its height to 0. This change does not address the difference in behavior between NTPs and regular web pages with the bookmarks bar, but it prevents the browser window from programmatically dropping below its min height. Added a unit test, and also had to adjust a unit test that created browser windows with a height < 200 (min height for a browser window is 272). BUG=230400 TEST=Create a browser window, confirm that View -> Always Show Bookmarks Bar is checked, navigate to www.google.com, resize the window to its minimum height, choose View -> Always Show Bookmarks Bar - the browser window's bookmarks bar should disappear, but the browser window's height should not change. Review URL: https://codereview.chromium.org/1052123006 Cr-Commit-Position: refs/heads/master@{#325267}
Diffstat (limited to 'sdch/BUILD.gn')
0 files changed, 0 insertions, 0 deletions