BitmapPlatformDevice multiply-inherits from PlatformDevice and SkDevice, in

that order.  However, a newly-created BitmapPlatformDevice is often upcast to
an SkDevice, and owning pointers are stored to it as an SkDevice.  All the
relevant destructors are virtual, so it can safely be deleted polymorphically.
However, valgrind doesn't know that, and at program exit some
BitmapPlatformDevices are still reachable only as SkDevices, pointing to the
middle of the BitmapPlatformDevice.

The real solution would be to get rid of the MI, but for now just switching
the base classes around causes valgrind to shut up, since we're now owning
the object through the same pointer that we got from new.  This moves the 
memory in valgrind from "possibly lost" to "still reachable".

BUG=105744
TEST=see valgrind output, check that errors go away
Review URL: https://chromiumcodereview.appspot.com/9900001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129616 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 1 insertions, 1 deletions

diff --git a/skia/ext/bitmap_platform_device_linux.h b/skia/ext/bitmap_platform_device_linux.h
index 02132f0..1ab85d4 100644
--- a/skia/ext/bitmap_platform_device_linux.h
+++ b/skia/ext/bitmap_platform_device_linux.h
@@ -57,7 +57,7 @@ namespace skia {
 // shared memory between the renderer and the main process at least. In this
 // case we'll probably create the buffer from a precreated region of memory.
 // -----------------------------------------------------------------------------
-class BitmapPlatformDevice : public PlatformDevice, public SkDevice {
+class BitmapPlatformDevice : public SkDevice, public PlatformDevice {
   // A reference counted cairo surface
   class BitmapPlatformDeviceData;