diff options
author | twiz@chromium.org <twiz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-17 19:09:12 +0000 |
---|---|---|
committer | twiz@chromium.org <twiz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-17 19:09:12 +0000 |
commit | 38846729c719211e1d0a51f3dfb565be650545ca (patch) | |
tree | a68620820aeba423774e0d704419b4d713c694dd /skia/ext/bitmap_platform_device_mac.h | |
parent | 33af5ea0d848f9377628536dd2f1dc197d8b4c03 (diff) | |
download | chromium_src-38846729c719211e1d0a51f3dfb565be650545ca.zip chromium_src-38846729c719211e1d0a51f3dfb565be650545ca.tar.gz chromium_src-38846729c719211e1d0a51f3dfb565be650545ca.tar.bz2 |
CL removing unused copy constructor and assignment operators on BitmapPlatformDevice. These classes should not have value semantics.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7204005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89534 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'skia/ext/bitmap_platform_device_mac.h')
-rw-r--r-- | skia/ext/bitmap_platform_device_mac.h | 20 |
1 files changed, 4 insertions, 16 deletions
diff --git a/skia/ext/bitmap_platform_device_mac.h b/skia/ext/bitmap_platform_device_mac.h index 67ef633..45fbcab 100644 --- a/skia/ext/bitmap_platform_device_mac.h +++ b/skia/ext/bitmap_platform_device_mac.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -6,6 +6,7 @@ #define SKIA_EXT_BITMAP_PLATFORM_DEVICE_MAC_H_ #pragma once +#include "base/basictypes.h" #include "skia/ext/platform_device_mac.h" namespace skia { @@ -44,23 +45,8 @@ class BitmapPlatformDevice : public PlatformDevice { int width, int height, bool is_opaque); - // Copy constructor. When copied, devices duplicate their internal data, so - // stay linked. This is because their implementation is very heavyweight - // (lots of memory and CoreGraphics state). If a device has been copied, both - // clip rects and other state will stay in sync. - // - // This means it will NOT work to duplicate a device and assign it to a - // canvas, because the two canvases will each set their own clip rects, and - // the resulting CoreGraphics drawing state will be unpredictable. - // - // Copy constucting and "=" is designed for saving the device or passing it - // around to another routine willing to deal with the bitmap data directly. - BitmapPlatformDevice(const BitmapPlatformDevice& other); virtual ~BitmapPlatformDevice(); - // See warning for copy constructor above. - BitmapPlatformDevice& operator=(const BitmapPlatformDevice& other); - // PlatformDevice overrides virtual CGContextRef GetBitmapContext(); virtual void DrawToNativeContext(CGContextRef context, int x, int y, @@ -91,6 +77,8 @@ class BitmapPlatformDevice : public PlatformDevice { // Data associated with this device, guaranteed non-null. We hold a reference // to this object. BitmapPlatformDeviceData* data_; + + DISALLOW_COPY_AND_ASSIGN(BitmapPlatformDevice); }; } // namespace skia |