diff options
| author | reveman@chromium.org <reveman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-30 21:48:37 +0000 |
|---|---|---|
| committer | reveman@chromium.org <reveman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-30 21:48:37 +0000 |
| commit | fb6703a5d072ca93dbed01405a6dfa60bb0200ee (patch) | |
| tree | 369e8e5d4f18c3951a79df2b5926cd34143cb9db /skia | |
| parent | 0e86dd3c3d2ea7c0ccd9c2471387ecfb124f0571 (diff) | |
| download | chromium_src-fb6703a5d072ca93dbed01405a6dfa60bb0200ee.zip chromium_src-fb6703a5d072ca93dbed01405a6dfa60bb0200ee.tar.gz chromium_src-fb6703a5d072ca93dbed01405a6dfa60bb0200ee.tar.bz2 | |
Revert 273648 "skia: Use medium filter quality in PaintSimplifier."
> skia: Use medium filter quality in PaintSimplifier.
>
> Preventing all bitmap filtering in the paint simplifier is a bad
> idea as it's very cache unfriendly when down-sampling due to
> requiring both the full size decoded image and the high/medium
> quality image normally used to be cached for good performance.
>
> However, forcing medium quality filtering is worthwhile as it's
> faster than high quality and still provides caching benefits.
>
> BUG=
>
> Review URL: https://codereview.chromium.org/305623008
Looks like this had a negative effect on memory usage.
TBR=reveman@chromium.org
BUG=379164
Review URL: https://codereview.chromium.org/308703006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273914 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'skia')
| -rw-r--r-- | skia/ext/paint_simplifier.cc | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/skia/ext/paint_simplifier.cc b/skia/ext/paint_simplifier.cc index c868257..8df91a8 100644 --- a/skia/ext/paint_simplifier.cc +++ b/skia/ext/paint_simplifier.cc @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include <limits> - #include "skia/ext/paint_simplifier.h" #include "third_party/skia/include/core/SkPaint.h" @@ -28,12 +26,6 @@ bool PaintSimplifier::filter(SkPaint* paint, Type type) { paint->setSubpixelText(false); paint->setLCDRenderText(false); - // Reduce filter level to medium or less. Note that reducing the filter to - // less than medium can have a negative effect on performance as the filtered - // image is not cached in this case. - paint->setFilterLevel( - std::min(paint->getFilterLevel(), SkPaint::kMedium_FilterLevel)); - paint->setMaskFilter(NULL); // Uncomment this line to shade simplified tiles pink during debugging. |