diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-11 23:46:03 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-11 23:47:30 +0000 |
| commit | 22ae18664ef32c6d4929480d617f35802e46274c (patch) | |
| tree | d67cc8136cbcc879ef66843e7970be2152cedfec /skia | |
| parent | 8d25ed5c4c9cbca7a656c7aae1da5beff14a29a6 (diff) | |
| download | chromium_src-22ae18664ef32c6d4929480d617f35802e46274c.zip chromium_src-22ae18664ef32c6d4929480d617f35802e46274c.tar.gz chromium_src-22ae18664ef32c6d4929480d617f35802e46274c.tar.bz2 | |
Remove -mimplicit-it=always from skia asm flags.
This was added to work around skia issue 297, but that's been fixed for years.
clang's integrated assembler doesn't understand -mimplicit-it=, so as it's not
needed here, just remove it.
BUG=86592,skia:297,124610
R=piman@chromium.org
Review URL: https://codereview.chromium.org/463653002
Cr-Commit-Position: refs/heads/master@{#288830}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288830 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'skia')
| -rw-r--r-- | skia/BUILD.gn | 7 | ||||
| -rw-r--r-- | skia/skia_library_opts.gyp | 7 |
2 files changed, 0 insertions, 14 deletions
diff --git a/skia/BUILD.gn b/skia/BUILD.gn index 3af03fa..f64b22d 100644 --- a/skia/BUILD.gn +++ b/skia/BUILD.gn @@ -629,13 +629,6 @@ source_set("skia_opts") { "//third_party/skia/src/opts/memset32_neon.S", ] - cflags += [ - # The neon assembly contains conditional instructions which aren't - # enclosed in an IT block. The assembler complains without this - # option. See #86592. - "-Wa,-mimplicit-it=always", - ] - # Root build config sets -mfpu=$arm_fpu, which we expect to be neon # when running this. if (!arm_use_neon) { diff --git a/skia/skia_library_opts.gyp b/skia/skia_library_opts.gyp index cb15f2d..cc00292 100644 --- a/skia/skia_library_opts.gyp +++ b/skia/skia_library_opts.gyp @@ -66,13 +66,6 @@ [ 'target_arch == "arm"', { 'conditions': [ [ 'arm_version >= 7 and (arm_neon == 1 or arm_neon_optional == 1)', { - 'cflags': [ - # The neon assembly contains conditional instructions which - # aren't enclosed in an IT block. The assembler complains - # without this option. - # See #86592. - '-Wa,-mimplicit-it=always', - ], 'dependencies': [ 'skia_opts_neon', ] |