Put debugging assertions into sql::Statement.

Pulls out the core of gbillock's http://codereview.chromium.org/8283002/
- Move NOTREACHED and similar checks into the sql:: implementation code.
- Add malformed SQL checks to Connection::Execute.
- Add SQL-checking convenience methods to Connection.

The general idea is that the sql:: framework assumes valid statements,
rather than having client code contain scattered ad-hoc (and thus
inconsistent) checks.

This version puts back Statement operator overloading and loosy-goosy
Execute() calls to allow other code to be updated in small batches.

R=gbillock@chromium.org,jhawkins@chromium.org,dhollowa@chromium.org 
BUG=none
TEST=sql_unittests,unit_tests:*Table*.*


Review URL: http://codereview.chromium.org/8899012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114118 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 0 insertions, 4 deletions

diff --git a/sql/statement_unittest.cc b/sql/statement_unittest.cc
index 1d10fe0..b6b6aa8 100644
--- a/sql/statement_unittest.cc
+++ b/sql/statement_unittest.cc
@@ -70,13 +70,9 @@ class SQLStatementTest : public testing::Test {
 
 TEST_F(SQLStatementTest, Assign) {
   sql::Statement s;
-  EXPECT_FALSE(s);  // bool conversion operator.
-  EXPECT_TRUE(!s);  // ! operator.
   EXPECT_FALSE(s.is_valid());
 
   s.Assign(db().GetUniqueStatement("CREATE TABLE foo (a, b)"));
-  EXPECT_TRUE(s);
-  EXPECT_FALSE(!s);
   EXPECT_TRUE(s.is_valid());
 }