diff options
| author | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-19 00:13:08 +0000 |
|---|---|---|
| committer | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-19 00:13:08 +0000 |
| commit | de679fb3bf4d8aa1f6f0fcb08dddd7cefce41f0c (patch) | |
| tree | e705f26560bd1a1819a90a831aa9be464985bd6f /sql | |
| parent | 8f115af1345aabd2c2367acf7fa4c9fadd5866a2 (diff) | |
| download | chromium_src-de679fb3bf4d8aa1f6f0fcb08dddd7cefce41f0c.zip chromium_src-de679fb3bf4d8aa1f6f0fcb08dddd7cefce41f0c.tar.gz chromium_src-de679fb3bf4d8aa1f6f0fcb08dddd7cefce41f0c.tar.bz2 | |
Revert [SQLite] Hack to touch page cache to debug slow connection close.
Original CL http://codereview.chromium.org/7891025 , http://crrev.com/101034
The hypothesis discussed in that CL seems proven out, as the
shutdown-hang crashes mostly moved from sqlite3_close() into
sqlite3_95527().
BUG=95527
TEST=Monitor crash in bug, see if it changes.
Review URL: https://chromiumcodereview.appspot.com/9845034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137989 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sql')
| -rw-r--r-- | sql/connection.cc | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/sql/connection.cc b/sql/connection.cc index b2274f1..a9c4974 100644 --- a/sql/connection.cc +++ b/sql/connection.cc @@ -125,21 +125,6 @@ void Connection::Close() { ClearCache(); if (db_) { - // TODO(shess): Some additional code to debug http://crbug.com/95527 . - // If you are reading this due to link errors or something, it can - // be safely removed. -#if defined(HAS_SQLITE3_95527) - unsigned int nTouched = 0; - sqlite3_95527(db_, &nTouched); - - // If a VERY large amount of memory was touched, crash. This - // should never happen. - // TODO(shess): Pull this in. It should be page_size * page_cache - // or something like that, 4M or 16M. For now it's just to - // prevent optimization. - CHECK_LT(nTouched, 1000*1000*1000U); -#endif - // TODO(shess): Histogram for failure. sqlite3_close(db_); db_ = NULL; |