diff options
author | mtomasz <mtomasz@chromium.org> | 2014-12-09 02:54:36 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-12-09 10:54:58 +0000 |
commit | a8ea1b0a6ee05bbbef78b0b7275c1177e60efca3 (patch) | |
tree | 5434469de3fbcfb395daaf1ec8ab6f5fd11b488a /storage/DEPS | |
parent | 5bcfb71ba1d2d3b8f94b5bdb2a19f8cdba58a928 (diff) | |
download | chromium_src-a8ea1b0a6ee05bbbef78b0b7275c1177e60efca3.zip chromium_src-a8ea1b0a6ee05bbbef78b0b7275c1177e60efca3.tar.gz chromium_src-a8ea1b0a6ee05bbbef78b0b7275c1177e60efca3.tar.bz2 |
Remove FileSystemContext::ShouldFlushOnWriteCompletion.
FileSystemContext::ShouldFlushOnWriteCompletion was used only for writing.
For streamed copying or moving, storage::CopySyncOption was used.
Even if both writing and copying is done via the same FileStreamWriter, the
decision about flushing it was done in two different ways.
This patch removes ShouldFlushOnWriteCompletion, as decision about flushing
should be the same for copying and writing, as both are writing operations
and data may be lost.
For sandboxed file systems storage::CopySyncOption::copy_sync_option() is
COPY_SYNC_OPTION_NO_SYNC, so there is no change. They will not be flushed.
For non-sandboxed file systems, they will be flushed consistently for write
and streamed copy/move, depending on storage::CopySyncOption.
The storage::CopySyncOption enum is going to be renamed to storage::
WriteSyncOption in an upcoming patch.
TEST=Partially by file_system_operation_impl_write_unittest.cc.
BUG=440293
Review URL: https://codereview.chromium.org/785193002
Cr-Commit-Position: refs/heads/master@{#307445}
Diffstat (limited to 'storage/DEPS')
0 files changed, 0 insertions, 0 deletions