diff options
author | maniscalco <maniscalco@chromium.org> | 2015-03-03 16:47:12 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-03-04 00:48:36 +0000 |
commit | f9648891191bb34bce0a4c4d0110d82dc23b9ee6 (patch) | |
tree | aaee4e673fdb500a8fad4ba059ef61972722a540 /sync/api | |
parent | 718dcc5bac721772b56655db19a0d6a745c21d25 (diff) | |
download | chromium_src-f9648891191bb34bce0a4c4d0110d82dc23b9ee6.zip chromium_src-f9648891191bb34bce0a4c4d0110d82dc23b9ee6.tar.gz chromium_src-f9648891191bb34bce0a4c4d0110d82dc23b9ee6.tar.bz2 |
[Sync] Remove DropAttachments from AttachmentService and SyncData
AttachmentService and SyncData no longer need to provide a drop method
beecause model type code can drop attachments using its AttachmentStore.
BUG=
Review URL: https://codereview.chromium.org/973513002
Cr-Commit-Position: refs/heads/master@{#318981}
Diffstat (limited to 'sync/api')
-rw-r--r-- | sync/api/sync_data.cc | 6 | ||||
-rw-r--r-- | sync/api/sync_data.h | 9 | ||||
-rw-r--r-- | sync/api/sync_data_unittest.cc | 4 |
3 files changed, 2 insertions, 17 deletions
diff --git a/sync/api/sync_data.cc b/sync/api/sync_data.cc index 7fbdbc2..0dd567d 100644 --- a/sync/api/sync_data.cc +++ b/sync/api/sync_data.cc @@ -218,10 +218,4 @@ void SyncDataRemote::GetOrDownloadAttachments( attachment_service_.GetOrDownloadAttachments(attachment_ids, callback); } -void SyncDataRemote::DropAttachments( - const AttachmentIdList& attachment_ids, - const AttachmentService::DropCallback& callback) { - attachment_service_.DropAttachments(attachment_ids, callback); -} - } // namespace syncer diff --git a/sync/api/sync_data.h b/sync/api/sync_data.h index 4e5acd3..6815896 100644 --- a/sync/api/sync_data.h +++ b/sync/api/sync_data.h @@ -190,15 +190,6 @@ class SYNC_EXPORT SyncDataRemote : public SyncData { void GetOrDownloadAttachments( const AttachmentIdList& attachment_ids, const AttachmentService::GetOrDownloadCallback& callback); - - // Drop (delete from local storage) the attachments associated with this - // SyncData specified in |attachment_ids|. This method will not delete - // attachments from the server. - // - // |callback| will be invoked when the operation is complete (successfully - // or otherwise). - void DropAttachments(const AttachmentIdList& attachment_ids, - const AttachmentService::DropCallback& callback); }; // gmock printer helper. diff --git a/sync/api/sync_data_unittest.cc b/sync/api/sync_data_unittest.cc index a0a83cd..94c3f4c 100644 --- a/sync/api/sync_data_unittest.cc +++ b/sync/api/sync_data_unittest.cc @@ -117,8 +117,8 @@ TEST_F(SyncDataTest, CreateRemoteData) { EXPECT_TRUE(data.GetAttachmentIds().empty()); } -// TODO(maniscalco): Add test cases that verify GetLocalAttachmentsForUpload and -// DropAttachments calls are passed through to the underlying AttachmentService. +// TODO(maniscalco): Add test cases that verify GetLocalAttachmentsForUpload +// calls are passed through to the underlying AttachmentService. } // namespace |