summaryrefslogtreecommitdiffstats
path: root/sync/engine
diff options
context:
space:
mode:
authorzea@chromium.org <zea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-07 02:30:24 +0000
committerzea@chromium.org <zea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-07 02:30:24 +0000
commit1f51ad94964af7f256ac1d762a04cfac1e9935c5 (patch)
tree621e43948dbd9825f0d1ab1f501ab0a91bbe9ede /sync/engine
parent3c372a1ae0e609691994bc74ade55175a3e2ea97 (diff)
downloadchromium_src-1f51ad94964af7f256ac1d762a04cfac1e9935c5.zip
chromium_src-1f51ad94964af7f256ac1d762a04cfac1e9935c5.tar.gz
chromium_src-1f51ad94964af7f256ac1d762a04cfac1e9935c5.tar.bz2
[Sync] Allow enabling partial sets of types instead of blocking
Blocking the datatype manager when datatypes fail to start is a sign of encryption issues, but is not fatal to sync. Therefore, it makes more sense to sync what we can (particularly so we can receive birthday updates), while marking those types with encryption problems as failed. To accomplish this we move all automatic reconfiguration logic into the data type manager itself, and add support for delayed association by unapplying all types with cryptographer errors. This also lays the groundwork for delayed association when a transaction version discrepancy is detected. BUG=238712 Review URL: https://chromiumcodereview.appspot.com/15013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204695 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/engine')
-rw-r--r--sync/engine/syncer_unittest.cc9
1 files changed, 6 insertions, 3 deletions
diff --git a/sync/engine/syncer_unittest.cc b/sync/engine/syncer_unittest.cc
index adae4f2..c1196ef 100644
--- a/sync/engine/syncer_unittest.cc
+++ b/sync/engine/syncer_unittest.cc
@@ -1092,6 +1092,7 @@ TEST_F(SyncerTest, TestPurgeWhileUnsynced) {
}
directory()->PurgeEntriesWithTypeIn(ModelTypeSet(PREFERENCES),
+ ModelTypeSet(),
ModelTypeSet());
SyncShareNudge();
@@ -1126,8 +1127,9 @@ TEST_F(SyncerTest, TestPurgeWhileUnapplied) {
parent.Put(syncable::ID, parent_id_);
}
- directory()->PurgeEntriesWithTypeIn(
- ModelTypeSet(BOOKMARKS), ModelTypeSet());
+ directory()->PurgeEntriesWithTypeIn(ModelTypeSet(BOOKMARKS),
+ ModelTypeSet(),
+ ModelTypeSet());
SyncShareNudge();
directory()->SaveChanges();
@@ -1165,7 +1167,8 @@ TEST_F(SyncerTest, TestPurgeWithJournal) {
}
directory()->PurgeEntriesWithTypeIn(ModelTypeSet(PREFERENCES, BOOKMARKS),
- ModelTypeSet(BOOKMARKS));
+ ModelTypeSet(BOOKMARKS),
+ ModelTypeSet());
{
// Verify bookmark nodes are saved in delete journal but not preference
// node.