Remove changes remaining counter from about:sync

The label "changes remaining" is not quite correct.  It's actually set
to either zero or one, depending on whether or not the current sync
cycle should result in more downloads.

If there is an issue with infinite download looping, we should be able
to detect and debug it based on the protocol logs, among other things.
The protocol logs indicate when a GetUpdates response had a non-zero
"changes remaining" value.

BUG=349301

Review URL: https://codereview.chromium.org/256413007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266594 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 6 insertions, 9 deletions

diff --git a/sync/engine/all_status.cc b/sync/engine/all_status.cc
index 3deda48..5a2f616 100644
--- a/sync/engine/all_status.cc
+++ b/sync/engine/all_status.cc
@@ -32,7 +32,6 @@ SyncStatus AllStatus::CreateBlankStatus() const {
   status.hierarchy_conflicts = 0;
   status.server_conflicts = 0;
   status.committed_count = 0;
-  status.updates_available = 0;
   return status;
 }
 
@@ -51,8 +50,6 @@ SyncStatus AllStatus::CalcSyncing(const SyncCycleEvent &event) const {
     status.syncing = false;
   }
 
-  status.updates_available += snapshot.num_server_changes_remaining();
-
   status.num_entries_by_type = snapshot.num_entries_by_type();
   status.num_to_delete_entries_by_type =
       snapshot.num_to_delete_entries_by_type();
diff --git a/sync/engine/get_updates_processor.cc b/sync/engine/get_updates_processor.cc
index 8666e0a..79be6c8 100644
--- a/sync/engine/get_updates_processor.cc
+++ b/sync/engine/get_updates_processor.cc
@@ -241,11 +241,10 @@ SyncerError GetUpdatesProcessor::ExecuteDownloadUpdates(
     return result;
   }
 
-  DVLOG(1) << "GetUpdates "
-           << " returned " << update_response.get_updates().entries_size()
-           << " updates and indicated "
-           << update_response.get_updates().changes_remaining()
-           << " updates left on server.";
+  DVLOG(1) << "GetUpdates returned "
+           << update_response.get_updates().entries_size()
+           << " updates.";
+
 
   if (session->context()->debug_info_getter()) {
     // Clear debug info now that we have successfully sent it to the server.
@@ -268,6 +267,8 @@ SyncerError GetUpdatesProcessor::ExecuteDownloadUpdates(
       base::Time::Now(), update_response, process_result);
   session->SendProtocolEvent(response_event);
 
+  DVLOG(1) << "GetUpdates result: " << process_result;
+
   return process_result;
 }
 
@@ -282,7 +283,6 @@ SyncerError GetUpdatesProcessor::ProcessResponse(
   if (!gu_response.has_changes_remaining()) {
     return SERVER_RESPONSE_VALIDATION_FAILED;
   }
-  status->set_num_server_changes_remaining(gu_response.changes_remaining());
 
   syncer::SyncerError result =
       ProcessGetUpdatesResponse(request_types, gu_response, status);