[Sync] Convert SyncSessionSnapshot to a copy-able class.

Previously it was an immutable struct that was passed around by making
dynamic allocations and passing pointers. We now just have a class with
only getters and no setters, but support for default copy and assign.

This cleans up some code and makes some future work easier to pass snapshots
around.

BUG=none
TEST=sync_unit_tests


Review URL: http://codereview.chromium.org/10197004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133747 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 2 insertions, 2 deletions

diff --git a/sync/internal_api/js_sync_manager_observer.cc b/sync/internal_api/js_sync_manager_observer.cc
index b9cf9f3..5aa9dc3 100644
--- a/sync/internal_api/js_sync_manager_observer.cc
+++ b/sync/internal_api/js_sync_manager_observer.cc
@@ -31,12 +31,12 @@ void JsSyncManagerObserver::SetJsEventHandler(
 }
 
 void JsSyncManagerObserver::OnSyncCycleCompleted(
-    const sessions::SyncSessionSnapshot* snapshot) {
+    const sessions::SyncSessionSnapshot& snapshot) {
   if (!event_handler_.IsInitialized()) {
     return;
   }
   DictionaryValue details;
-  details.Set("snapshot", snapshot->ToValue());
+  details.Set("snapshot", snapshot.ToValue());
   HandleJsEvent(FROM_HERE, "onSyncCycleCompleted", JsEventDetails(&details));
 }