diff options
| author | maniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-01 05:04:46 +0000 |
|---|---|---|
| committer | maniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-01 05:04:46 +0000 |
| commit | 1069f58d60a175fb1ebb4c65fbfec2711367c1ea (patch) | |
| tree | 0d180a1150a8aafd9dc2ebfc1adf2f792e124cee /sync/internal_api/public | |
| parent | d35e0d5c14cefc63528e51b624ea985d02406371 (diff) | |
| download | chromium_src-1069f58d60a175fb1ebb4c65fbfec2711367c1ea.zip chromium_src-1069f58d60a175fb1ebb4c65fbfec2711367c1ea.tar.gz chromium_src-1069f58d60a175fb1ebb4c65fbfec2711367c1ea.tar.bz2 | |
Update sync API to support attachments.
The purpose of this change is to start exposing attachment support in
the sync API. At this point there is no real functionality added.
SyncData and SyncChangeProcessor now know about attachments.
GenericChangeProcessor's ctor now requires an AttachmentService.
Add AttachmentService and FakeAttachmentService.
Update Attachment::Create* methods to return by value.
Make Attachment::CreateId public because it is useful in
sync_data_unittest.cc.
Make some ctors explicit.
BUG=348624
Review URL: https://codereview.chromium.org/187303006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260778 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/internal_api/public')
| -rw-r--r-- | sync/internal_api/public/DEPS | 1 | ||||
| -rw-r--r-- | sync/internal_api/public/base_node.h | 4 |
2 files changed, 5 insertions, 0 deletions
diff --git a/sync/internal_api/public/DEPS b/sync/internal_api/public/DEPS index 877a88d..b9d4591 100644 --- a/sync/internal_api/public/DEPS +++ b/sync/internal_api/public/DEPS @@ -1,5 +1,6 @@ include_rules = [ "-sync", + "+sync/api", "+sync/base", "+sync/internal_api/public", "+sync/notifier", diff --git a/sync/internal_api/public/base_node.h b/sync/internal_api/public/base_node.h index 425a81f..93d2baf 100644 --- a/sync/internal_api/public/base_node.h +++ b/sync/internal_api/public/base_node.h @@ -12,6 +12,7 @@ #include "base/gtest_prod_util.h" #include "base/memory/scoped_ptr.h" #include "base/time/time.h" +#include "sync/api/attachments/attachment.h" #include "sync/base/sync_export.h" #include "sync/internal_api/public/base/model_type.h" #include "sync/protocol/sync.pb.h" @@ -200,6 +201,9 @@ class SYNC_EXPORT BaseNode { // (ie. non-bookmarks). int GetPositionIndex() const; + // Returns this item's attachment ids. + const syncer::AttachmentIdList GetAttachmentIds() const; + // These virtual accessors provide access to data members of derived classes. virtual const syncable::Entry* GetEntry() const = 0; virtual const BaseTransaction* GetTransaction() const = 0; |