summaryrefslogtreecommitdiffstats
path: root/sync/internal_api/sync_manager_impl.cc
diff options
context:
space:
mode:
authorrlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-08-09 07:24:46 +0000
committerrlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-08-09 07:24:46 +0000
commitc39863f6f5e1f5919e5eefbfe523803804c87500 (patch)
treee5d5c7006a07ce1b5da3908cff6836d3393538b6 /sync/internal_api/sync_manager_impl.cc
parente79f26e79c7a547daea7ffb9fed3755b82641077 (diff)
downloadchromium_src-c39863f6f5e1f5919e5eefbfe523803804c87500.zip
chromium_src-c39863f6f5e1f5919e5eefbfe523803804c87500.tar.gz
chromium_src-c39863f6f5e1f5919e5eefbfe523803804c87500.tar.bz2
Remove SyncManager::Init() return value
The return value was almost entirely unusued. Success or failure is reported through a parameter in the asynchronous callback function. BUG=140180 Review URL: https://chromiumcodereview.appspot.com/10826193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150763 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/internal_api/sync_manager_impl.cc')
-rw-r--r--sync/internal_api/sync_manager_impl.cc6
1 files changed, 3 insertions, 3 deletions
diff --git a/sync/internal_api/sync_manager_impl.cc b/sync/internal_api/sync_manager_impl.cc
index 72f936f..16232f4 100644
--- a/sync/internal_api/sync_manager_impl.cc
+++ b/sync/internal_api/sync_manager_impl.cc
@@ -362,7 +362,7 @@ void SyncManagerImpl::ConfigureSyncer(
}
-bool SyncManagerImpl::Init(
+void SyncManagerImpl::Init(
const FilePath& database_location,
const WeakHandle<JsEventHandler>& event_handler,
const std::string& sync_server_and_path,
@@ -428,7 +428,8 @@ bool SyncManagerImpl::Init(
OnInitializationComplete(
MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()),
false, syncer::ModelTypeSet()));
- return false;
+ LOG(ERROR) << "Sync manager initialization failed!";
+ return;
}
connection_manager_.reset(new SyncAPIServerConnectionManager(
@@ -495,7 +496,6 @@ bool SyncManagerImpl::Init(
OnInitializationComplete(
MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()),
true, InitialSyncEndedTypes()));
- return true;
}
void SyncManagerImpl::RefreshNigori(const std::string& chrome_version,