diff options
| author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-13 04:28:33 +0000 |
|---|---|---|
| committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-13 04:28:33 +0000 |
| commit | 6bb19a6ed084dafd380a30c0098452acbc92fa6d (patch) | |
| tree | 85f39471ddd69eefaa5bb3adcd77eb1633893263 /sync/internal_api | |
| parent | dedd11a1706e63fed812b5ffa67756402c99fc42 (diff) | |
| download | chromium_src-6bb19a6ed084dafd380a30c0098452acbc92fa6d.zip chromium_src-6bb19a6ed084dafd380a30c0098452acbc92fa6d.tar.gz chromium_src-6bb19a6ed084dafd380a30c0098452acbc92fa6d.tar.bz2 | |
[Sync] Add tests for invalid specifics field number handling
This is a follow up to r172232.
Change NOTREACHED() to DLOG(WARNING), since the server sending down
unknown/invalid field numbers is a valid event.
Add tests for the code that uses GetModelTypeFromSpecificsFieldNumber().
Clean up some code in sync/engine/ a bit.
BUG=165171
Review URL: https://chromiumcodereview.appspot.com/11485019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172816 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/internal_api')
| -rw-r--r-- | sync/internal_api/public/base/model_type.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sync/internal_api/public/base/model_type.h b/sync/internal_api/public/base/model_type.h index 5b9b92d..23ca2d8 100644 --- a/sync/internal_api/public/base/model_type.h +++ b/sync/internal_api/public/base/model_type.h @@ -174,7 +174,7 @@ SYNC_EXPORT bool IsControlType(ModelType model_type); // ModelType model_type = // GetModelTypeFromSpecificsFieldNumber(field_number); // if (!IsRealDataType(model_type)) { -// NOTREACHED() << "Unknown field number " << field_number; +// DLOG(WARNING) << "Unknown field number " << field_number; // continue; // } // model_types.Put(model_type); |