Remove changes remaining counter from about:sync

The label "changes remaining" is not quite correct.  It's actually set
to either zero or one, depending on whether or not the current sync
cycle should result in more downloads.

If there is an issue with infinite download looping, we should be able
to detect and debug it based on the protocol logs, among other things.
The protocol logs indicate when a GetUpdates response had a non-zero
"changes remaining" value.

BUG=349301

Review URL: https://codereview.chromium.org/256413007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266594 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 0 insertions, 17 deletions

diff --git a/sync/sessions/status_controller.cc b/sync/sessions/status_controller.cc
index 666504f..4610a51 100644
--- a/sync/sessions/status_controller.cc
+++ b/sync/sessions/status_controller.cc
@@ -32,11 +32,6 @@ void StatusController::increment_num_reflected_updates_downloaded_by(
   model_neutral_.num_reflected_updates_downloaded_total += value;
 }
 
-void StatusController::set_num_server_changes_remaining(
-    int64 changes_remaining) {
-  model_neutral_.num_server_changes_remaining = changes_remaining;
-}
-
 void StatusController::UpdateStartTime() {
   sync_start_time_ = base::Time::Now();
 }
diff --git a/sync/sessions/status_controller.h b/sync/sessions/status_controller.h
index 51fa3ce..9844929 100644
--- a/sync/sessions/status_controller.h
+++ b/sync/sessions/status_controller.h
@@ -43,11 +43,6 @@ class SYNC_EXPORT_PRIVATE StatusController {
     model_neutral_.commit_request_types = value;
   }
 
-  // Changelog related state.
-  int64 num_server_changes_remaining() const {
-    return model_neutral_.num_server_changes_remaining;
-  }
-
   // Various conflict counters.
   int num_encryption_conflicts() const;
   int num_hierarchy_conflicts() const;
@@ -73,7 +68,6 @@ class SYNC_EXPORT_PRIVATE StatusController {
   SyncerError last_get_key_result() const;
 
   // Download counters.
-  void set_num_server_changes_remaining(int64 changes_remaining);
   void increment_num_updates_downloaded_by(int value);
   void increment_num_tombstone_updates_downloaded_by(int value);
   void increment_num_reflected_updates_downloaded_by(int value);
diff --git a/sync/sessions/status_controller_unittest.cc b/sync/sessions/status_controller_unittest.cc
index c29bc5f..56bc987 100644
--- a/sync/sessions/status_controller_unittest.cc
+++ b/sync/sessions/status_controller_unittest.cc
@@ -16,8 +16,6 @@ class StatusControllerTest : public testing::Test { };
 // method was actually setting |bar_| instead!).
 TEST_F(StatusControllerTest, ReadYourWrites) {
   StatusController status;
-  status.set_num_server_changes_remaining(13);
-  EXPECT_EQ(13, status.num_server_changes_remaining());
 
   status.set_last_download_updates_result(SYNCER_OK);
   EXPECT_EQ(SYNCER_OK,
diff --git a/sync/sessions/test_util.cc b/sync/sessions/test_util.cc
index 95db11b..0555d86 100644
--- a/sync/sessions/test_util.cc
+++ b/sync/sessions/test_util.cc
@@ -22,7 +22,6 @@ void SimulateConfigureSuccess(
     ModelTypeSet requsted_types,
     sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source,
     sessions::SyncSession* session) {
-  ASSERT_EQ(0U, session->status_controller().num_server_changes_remaining());
   session->mutable_status_controller()->set_last_get_key_result(SYNCER_OK);
   session->mutable_status_controller()->set_last_download_updates_result(
       SYNCER_OK);
@@ -49,7 +48,6 @@ void SimulateConfigureConnectionFailure(
 void SimulateNormalSuccess(ModelTypeSet requested_types,
                            const sessions::NudgeTracker& nudge_tracker,
                            sessions::SyncSession* session) {
-  ASSERT_EQ(0U, session->status_controller().num_server_changes_remaining());
   session->mutable_status_controller()->set_commit_result(SYNCER_OK);
   session->mutable_status_controller()->set_last_download_updates_result(
       SYNCER_OK);
@@ -83,14 +81,12 @@ void SimulateConnectionFailure(
 
 void SimulatePollSuccess(ModelTypeSet requested_types,
                          sessions::SyncSession* session) {
-  ASSERT_EQ(0U, session->status_controller().num_server_changes_remaining());
   session->mutable_status_controller()->set_last_download_updates_result(
       SYNCER_OK);
 }
 
 void SimulatePollFailed(ModelTypeSet requested_types,
                              sessions::SyncSession* session) {
-  ASSERT_EQ(0U, session->status_controller().num_server_changes_remaining());
   session->mutable_status_controller()->set_last_download_updates_result(
       SERVER_RETURN_TRANSIENT_ERROR);
 }