diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-04 03:51:01 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-04 03:51:01 +0000 |
| commit | 163d063581234f5b22fb8412ccbd47d772b31b22 (patch) | |
| tree | 200dbe509a421665a43411987ca8788c1fe1efcf /sync/sync_internal_api.gypi | |
| parent | eb805dc5dd911e0ea1cf2c0ada33a6fe169e11f1 (diff) | |
| download | chromium_src-163d063581234f5b22fb8412ccbd47d772b31b22.zip chromium_src-163d063581234f5b22fb8412ccbd47d772b31b22.tar.gz chromium_src-163d063581234f5b22fb8412ccbd47d772b31b22.tar.bz2 | |
Refactor common invalidation framework types
Convert the Invalidation struct into a class. This allows us to hide
its members, so we can do things like add a DCHECK to make sure we never
access the payload field of an unknown version invalidation. It also
lets us use factory methods and constructors to initialize it rather
than having to initialize its fields one by one.
Convert the ObjectIdInvalidationMap from a typedef into a class. Unlike
the typedef, the class supports multiple invalidations for the same
object ID. It uses the newly introduced SingleObjectInvalidationSet to
manage the set of invalidations belonging to a particular ID. Note that
the current code still sends only one invalidation per type; that will
be changed in a future commit.
The end goal of this refactoring is to make these classes smarter so
they can help manage the complexity that will be introduced when we
implement invalidation 'trickles' support.
Note that this commit changes the on-disk format for invalidations, so
any invalidations currently stored in the profile may be lost on
upgrade. There should be no other notable changes to invalidations
behavior in this CL.
TBR=brettw
BUG=233437
Review URL: https://codereview.chromium.org/23441042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226949 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/sync_internal_api.gypi')
| -rw-r--r-- | sync/sync_internal_api.gypi | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sync/sync_internal_api.gypi b/sync/sync_internal_api.gypi index be3ce71..f9aeeca 100644 --- a/sync/sync_internal_api.gypi +++ b/sync/sync_internal_api.gypi @@ -32,6 +32,8 @@ 'internal_api/js_sync_encryption_handler_observer.h', 'internal_api/js_sync_manager_observer.cc', 'internal_api/js_sync_manager_observer.h', + 'internal_api/public/base/ack_handle.cc', + 'internal_api/public/base/ack_handle.h', 'internal_api/public/base/cancelation_observer.cc', 'internal_api/public/base/cancelation_observer.h', 'internal_api/public/base/cancelation_signal.cc', @@ -67,8 +69,8 @@ 'internal_api/public/http_bridge.h', 'internal_api/public/http_post_provider_factory.h', 'internal_api/public/http_post_provider_interface.h', - 'internal_api/public/internal_components_factory_impl.h', 'internal_api/public/internal_components_factory.h', + 'internal_api/public/internal_components_factory_impl.h', 'internal_api/public/read_node.h', 'internal_api/public/read_transaction.h', 'internal_api/public/sessions/model_neutral_state.cc', |