summaryrefslogtreecommitdiffstats
path: root/sync/sync_proto.gypi
diff options
context:
space:
mode:
authorrlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-08-01 23:41:44 +0000
committerrlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-08-01 23:41:44 +0000
commita579f97a55d027dd38187bc9a801e528e91a6500 (patch)
tree97801a9a7bb15b9c0e96f4245b78bd9c2507ba4e /sync/sync_proto.gypi
parentc5bbe0e28607eaec46fe76ee44292daa9784e22c (diff)
downloadchromium_src-a579f97a55d027dd38187bc9a801e528e91a6500.zip
chromium_src-a579f97a55d027dd38187bc9a801e528e91a6500.tar.gz
chromium_src-a579f97a55d027dd38187bc9a801e528e91a6500.tar.bz2
Refactor build target for sync
Refactors the sync build target definition to fit the more common pattern. The old target was defined differently in component and non-component mode. This is brittle compared to the more standard pattern of setting the target type to '<(component)'. Introduces a shim target with type 'none'. Any target that depends on this shim will link inherit its dependency on the two sync libraries. A note on the history of this, for those who are interested: This pattern was recommended during the original componentization of sync almost two years ago. The pattern was, and still is, used by content.gyp to ensure that dependency restrictions are being respected. The difference with sync is that it doesn't actually make use of fine-grained dependencies. It's not unusual to see a target depend on conent_renderer, content_browser, or some other static library sub-component of content. With sync, on the other hand, we have the rule that other targets may depend only on the top level sync target. Since no one aside from sync depends on sync_internal_api, sync_core, or sync_api static library targets, and we have no intention of exposing these sub-components outside of sync, there's no point in maintaining them as separate targets. BUG=397574 Review URL: https://codereview.chromium.org/425803013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287119 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/sync_proto.gypi')
-rw-r--r--sync/sync_proto.gypi64
1 files changed, 0 insertions, 64 deletions
diff --git a/sync/sync_proto.gypi b/sync/sync_proto.gypi
deleted file mode 100644
index fd002bf..0000000
--- a/sync/sync_proto.gypi
+++ /dev/null
@@ -1,64 +0,0 @@
-# Copyright 2013 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-{
- 'include_dirs': [
- '..',
- ],
- 'defines': [
- 'SYNC_IMPLEMENTATION',
- ],
- 'sources': [
- # NOTE: If you add a file to this list, also add it to
- # sync/protocol/BUILD.gn
- 'protocol/app_notification_specifics.proto',
- 'protocol/app_setting_specifics.proto',
- 'protocol/app_specifics.proto',
- 'protocol/app_list_specifics.proto',
- 'protocol/article_specifics.proto',
- 'protocol/attachments.proto',
- 'protocol/autofill_specifics.proto',
- 'protocol/bookmark_specifics.proto',
- 'protocol/client_commands.proto',
- 'protocol/client_debug_info.proto',
- 'protocol/device_info_specifics.proto',
- 'protocol/dictionary_specifics.proto',
- 'protocol/encryption.proto',
- 'protocol/experiments_specifics.proto',
- 'protocol/extension_setting_specifics.proto',
- 'protocol/extension_specifics.proto',
- 'protocol/favicon_image_specifics.proto',
- 'protocol/favicon_tracking_specifics.proto',
- 'protocol/get_updates_caller_info.proto',
- 'protocol/history_delete_directive_specifics.proto',
- 'protocol/nigori_specifics.proto',
- 'protocol/managed_user_setting_specifics.proto',
- 'protocol/managed_user_shared_setting_specifics.proto',
- 'protocol/managed_user_specifics.proto',
- 'protocol/password_specifics.proto',
- 'protocol/preference_specifics.proto',
- 'protocol/priority_preference_specifics.proto',
- 'protocol/search_engine_specifics.proto',
- 'protocol/session_specifics.proto',
- 'protocol/sync.proto',
- 'protocol/sync_enums.proto',
- 'protocol/synced_notification_app_info_specifics.proto',
- 'protocol/synced_notification_data.proto',
- 'protocol/synced_notification_render.proto',
- 'protocol/synced_notification_specifics.proto',
- 'protocol/test.proto',
- 'protocol/theme_specifics.proto',
- 'protocol/typed_url_specifics.proto',
- 'protocol/unique_position.proto',
- ],
- 'variables': {
- 'proto_in_dir': './protocol',
- 'proto_out_dir': 'sync/protocol',
- 'cc_generator_options': 'dllexport_decl=SYNC_EXPORT:',
- 'cc_include': 'sync/base/sync_export.h',
- },
- 'includes': [
- '../build/protoc.gypi'
- ],
-}