diff options
author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-02 23:16:34 +0000 |
---|---|---|
committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-02 23:16:34 +0000 |
commit | d1929aaf01ac9c3166d31b3eeaaf2676629cebcb (patch) | |
tree | 4218d03dcb01b02a41a2eef448e5009202035855 /sync/sync_tests.gypi | |
parent | 713eac6708cdadc256d996e6695a4ee9d09212d8 (diff) | |
download | chromium_src-d1929aaf01ac9c3166d31b3eeaaf2676629cebcb.zip chromium_src-d1929aaf01ac9c3166d31b3eeaaf2676629cebcb.tar.gz chromium_src-d1929aaf01ac9c3166d31b3eeaaf2676629cebcb.tar.bz2 |
Revert of Move some sync/notifier to components/invalidation (https://codereview.chromium.org/294123004/)
Reason for revert:
Passed the CQ but broke the buildbot.
Original issue's description:
> Move some sync/notifier to components/invalidation
>
> Moves many of the files in sync/notifier to components/invalidation.
>
> This change does not introduce any new dependencies. The relevant
> dependency rules both before and after this change should be:
> - chrome/browser/invalidation and chrome in general depend on
> components/invalidation.
> - components/invalidation depends on sync/notifier and sync in
> general.
> - sync/notifier, components/invalidation, and various parts of
> chrome all depend on sync/internal_api/public.
>
> The eventual goal is to move all of sync/notifier into
> components/invalidation. The invalidation-related parts of
> sync/internal_api/public should be moved to components/invalidation,
> too. This will allow us to remove the deopendencies from
> components/invalidation to sync, and remove sync's dependencies on
> cacheinvalidation and libjingle.
>
> This change is a regression in terms of shared library componentization.
> the files in the sync/notifier folder could be built as a shared
> library. The files in compononents/invalidation do not support this
> yet. The SYNC_EXPORT declarations in the moved files have been changed
> to INVALIDATION_EXPORT so as to not lose this information, but the
> macros are currently #defined to no-ops.
>
> This change does not attempt to rename any classes or namespaces.
> Many of the files ported from sync/notifier still use the syncer
> namespace. Some, like SyncSystemResources, still have names tied
> to their sync heritage. This will be addressed in future CLs.
>
> Some non-trivial or non-obvious changes include:
> - invalidator_state.h was moved to sync/internal_api/public/base so it
> could be shared by both sync/ and components/invalidation. This should
> be fixed in a future CL.
> - FromNotifierReason was split out of invalidator_state.h and moved to
> the newly-created components/invalidator_reason_util.h
>
> TBR=zea,rtenneti,mallinath,dcheng
> BUG=259559
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274350
TBR=pavely@chromium.org,dcheng@chromium.org,zea@chromium.org,rtenneti@chromium.org,mallinath@chromium.org,maniscalco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=259559
Review URL: https://codereview.chromium.org/308413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274364 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/sync_tests.gypi')
-rw-r--r-- | sync/sync_tests.gypi | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/sync/sync_tests.gypi b/sync/sync_tests.gypi index e92d6c4..cd4f933 100644 --- a/sync/sync_tests.gypi +++ b/sync/sync_tests.gypi @@ -159,6 +159,14 @@ 'sync', ], 'sources': [ + 'notifier/fake_invalidation_handler.cc', + 'notifier/fake_invalidation_handler.h', + 'notifier/fake_invalidation_state_tracker.cc', + 'notifier/fake_invalidation_state_tracker.h', + 'notifier/fake_invalidator.cc', + 'notifier/fake_invalidator.h', + 'notifier/invalidator_test_template.cc', + 'notifier/invalidator_test_template.h', 'notifier/unacked_invalidation_set_test_util.cc', 'notifier/unacked_invalidation_set_test_util.h', 'internal_api/public/base/object_id_invalidation_map_test_util.h', @@ -366,9 +374,18 @@ 'conditions': [ ['OS != "android"', { 'sources': [ + 'notifier/fake_invalidator_unittest.cc', + 'notifier/gcm_network_channel_unittest.cc', + 'notifier/invalidation_notifier_unittest.cc', + 'notifier/invalidator_registrar_unittest.cc', + 'notifier/non_blocking_invalidator_unittest.cc', 'notifier/object_id_invalidation_map_unittest.cc', + 'notifier/p2p_invalidator_unittest.cc', + 'notifier/push_client_channel_unittest.cc', 'notifier/registration_manager_unittest.cc', 'notifier/single_object_invalidation_set_unittest.cc', + 'notifier/sync_invalidation_listener_unittest.cc', + 'notifier/sync_system_resources_unittest.cc', 'notifier/unacked_invalidation_set_unittest.cc', ], }], |