diff options
author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-11 22:27:54 +0000 |
---|---|---|
committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-11 22:27:54 +0000 |
commit | 870bcb302d6597636fee73cd7bac110664b5a51d (patch) | |
tree | ba441b6275c472d77b3b4e9f0d64d8a9ab2017a6 /sync/test/fake_extensions_activity_monitor.cc | |
parent | 00cee28d45333558a3b7d842923d8e2eb07d7696 (diff) | |
download | chromium_src-870bcb302d6597636fee73cd7bac110664b5a51d.zip chromium_src-870bcb302d6597636fee73cd7bac110664b5a51d.tar.gz chromium_src-870bcb302d6597636fee73cd7bac110664b5a51d.tar.bz2 |
RefCounted types should not have public destructors - sync and jingle
In the process of ensuring no base classes for RefCounted classes have
public destructors, base::NonThreadSafe shows up frequently due to having
a public destructor.
Begin migrating all the code that has a base::NonThreadSafe member to
directly inheriting from base::NonThreadSafe, so that base::NonThreadSafe's
destructor can be made private.
BUG=123295
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/10411046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141530 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/test/fake_extensions_activity_monitor.cc')
-rw-r--r-- | sync/test/fake_extensions_activity_monitor.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sync/test/fake_extensions_activity_monitor.cc b/sync/test/fake_extensions_activity_monitor.cc index b3e38cd..4cf5042 100644 --- a/sync/test/fake_extensions_activity_monitor.cc +++ b/sync/test/fake_extensions_activity_monitor.cc @@ -11,17 +11,17 @@ namespace browser_sync { FakeExtensionsActivityMonitor::FakeExtensionsActivityMonitor() {} FakeExtensionsActivityMonitor::~FakeExtensionsActivityMonitor() { - DCHECK(non_thread_safe_.CalledOnValidThread()); + DCHECK(CalledOnValidThread()); } void FakeExtensionsActivityMonitor::GetAndClearRecords(Records* buffer) { - DCHECK(non_thread_safe_.CalledOnValidThread()); + DCHECK(CalledOnValidThread()); buffer->clear(); buffer->swap(records_); } void FakeExtensionsActivityMonitor::PutRecords(const Records& records) { - DCHECK(non_thread_safe_.CalledOnValidThread()); + DCHECK(CalledOnValidThread()); for (Records::const_iterator i = records.begin(); i != records.end(); ++i) { records_[i->first].extension_id = i->second.extension_id; records_[i->first].bookmark_write_count += i->second.bookmark_write_count; |